Add GPU memory tab to the task manager.

chrome/browser/ui/webui/task_manager/task_manager_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/task_manager/task_manager_handler.h"
 
 #include <algorithm>
 #include <functional>
 
 #include "base/bind.h"
@@ skipping 86 matching lines @@
     tm->GetWebCoreCacheStats(i, &resource_stats);
     return Value::CreateDoubleValue(resource_stats.cssStyleSheets.size);
   }
   if (column_name == "fps")
     return Value::CreateStringValue(tm->GetResourceFPS(i));
   if (column_name == "fpsValue") {
     float fps;
     tm->GetFPS(i, &fps);
     return Value::CreateDoubleValue(fps);
   }
+  if (column_name == "vidmem")
+    return Value::CreateStringValue(tm->GetResourceVidmem(i));
+  if (column_name == "vidmemValue") {
+    size_t vidmem;
+    bool has_duplicates;
+    tm->GetVidmem(i, &vidmem, &has_duplicates);

[yoshiki, 2012/08/16 06:25:59]

Could you handle explicitly GetVidmem() failure? I think you should set
std::numeric_limits<std::size_t>::max() or
std::numeric_limits<std::size_t>::min().

[yoshiki, 2012/08/16 06:27:03]

Sorry, not std::size_t, but double.

[ccameron, 2012/08/16 17:58:30]

GetVidmem will set the value to its minimum (0) on failure, but to be explicit,
I've set it explicitly to 0.

[ccameron, 2012/08/16 17:58:30]

Done.

[ccameron, 2012/08/16 17:58:30]

Done.

+    return Value::CreateDoubleValue(vidmem);
+  }
   if (column_name == "sqliteMemoryUsed")
     return Value::CreateStringValue(tm->GetResourceSqliteMemoryUsed(i));
   if (column_name == "sqliteMemoryUsedValue") {
     size_t sqlite_memory;
     tm->GetSqliteMemoryUsedBytes(i, &sqlite_memory);
     return Value::CreateDoubleValue(sqlite_memory);
   }
   if (column_name == "goatsTeleported")
     return Value::CreateStringValue(tm->GetResourceGoatsTeleported(i));
   if (column_name == "goatsTeleportedValue")
@@ skipping 46 matching lines @@
   {"webCoreImageCacheSize", true, false},
   {"webCoreScriptsCacheSize", true, false},
   {"webCoreCSSCacheSize", true, false},
   {"sqliteMemoryUsed", true, false},
   {"v8MemoryAllocatedSize", true, false},
   {"icon", false, true},
   {"title", false, true},
   {"profileName", false, true},
   {"networkUsage", true, true},
   {"fps", true, true},
+  {"vidmemColumn", true, false},

[yoshiki, 2012/08/16 06:25:59]

s/vidmemColumn/vidmem/

[ccameron, 2012/08/16 17:58:30]

Done.

   {"goatsTeleported", true, true},
   {"canInspect", false, true},
   {"canActivate", false, true}
 };
 
 DictionaryValue* CreateTaskGroupValue(
     const TaskManagerModel* tm,
     const int group_index,
     const std::set<std::string>& columns) {
   DictionaryValue* val = new DictionaryValue();
@@ skipping 216 matching lines @@
 void TaskManagerHandler::OnGroupAdded(const int group_start,
                                       const int group_length) {
 }
 
 void TaskManagerHandler::OnGroupRemoved(const int group_start,
                                         const int group_length) {
 }
 
 void TaskManagerHandler::OnReadyPeriodicalUpdate() {
 }