content/public/common/gpu_memory_stats.cc - Issue 10854076: Add GPU memory tab to the task manager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/gpu_memory_stats.cc

Issue 10854076: Add GPU memory tab to the task manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporate review feedback Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	jam 2012/08/17 22:47:09 nit: are you sure you need a cc file and construct nit: are you sure you need a cc file and constructors/destructors? clang sometimes needs them in case of complex c'tors/d'tors, but I don't know the exact formula that it uses. if you can avoid it, that's better. ccameron 2012/08/17 22:52:36 I tried to avoid it in an earlier version, but cla Show quoted text On 2012/08/17 22:47:09, John Abd-El-Malek wrote: > nit: are you sure you need a cc file and constructors/destructors? clang > sometimes needs them in case of complex c'tors/d'tors, but I don't know the > exact formula that it uses. if you can avoid it, that's better. I tried to avoid it in an earlier version, but clang wasn't happy with it. This strictness seemed to be particular to the content directory.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/public/common/gpu_memory_stats.h"

	6

	7 namespace content {

	8

	9 GPUVideoMemoryUsageStats::GPUVideoMemoryUsageStats() {

	10 }

	11

	12 GPUVideoMemoryUsageStats::~GPUVideoMemoryUsageStats() {

	13 }

	14

	15 GPUVideoMemoryUsageStats::ProcessStats::ProcessStats()

	16 : video_memory(0),

	17 has_duplicates(false) {

	18 }

	19

	20 GPUVideoMemoryUsageStats::ProcessStats::~ProcessStats() {

	21 }

	22

	23 } // namespace content

OLD	NEW