Add GPU memory tab to the task manager.

content/public/common/gpu_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_GPU_INFO_H_
 #define CONTENT_PUBLIC_COMMON_GPU_INFO_H_
 
 // Provides access to the GPU information for the system
 // on which chrome is currently running.
 
+#include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
+#include "base/process.h"
 #include "base/time.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "content/public/common/dx_diag_node.h"
 #include "content/public/common/gpu_performance_stats.h"
 
 namespace content {
 
 struct CONTENT_EXPORT GPUInfo {
   struct CONTENT_EXPORT GPUDevice {
@@ skipping 78 matching lines @@
   GpuPerformanceStats performance_stats;
 
   bool software_rendering;
 
 #if defined(OS_WIN)
   // The information returned by the DirectX Diagnostics Tool.
   DxDiagNode dx_diagnostics;
 #endif
 };
 
+struct CONTENT_EXPORT GPUVidmemUsageStats {

[jam, 2012/08/17 18:31:05]

put this in a separate file (the convention in the content api is one file per
struct or class)

[jam, 2012/08/17 18:31:05]

nit: also VideoMemory per the style guide

[ccameron, 2012/08/17 20:52:55]

Moved to gpu_memory_stats.h

[ccameron, 2012/08/17 20:52:55]

Changed this everywhere in the patch.

+  GPUVidmemUsageStats();
+  ~GPUVidmemUsageStats();

[brettw, 2012/08/17 19:07:24]

I'd do a blank line after this.

[ccameron, 2012/08/17 20:52:55]

Done.

+  struct CONTENT_EXPORT GPUProcessVidmemUsageStats {

[brettw, 2012/08/17 19:07:24]

I might just call this something simpler like "ProcessStats" since it's in an
enclosing scope. GPUVidmemUsageStats::GPUProcessVidmemUsageStats seems like a
pain to type and not necessarily useful.

[ccameron, 2012/08/17 20:52:55]

Good idea, done.

+    GPUProcessVidmemUsageStats();
+    ~GPUProcessVidmemUsageStats();
+
+    // The bytes of GPU resources accessible by this process
+    size_t vidmem;

[jam, 2012/08/17 18:31:05]

nit: video_memory, per the style guide

[ccameron, 2012/08/17 20:52:55]

Changed this everywhere in the patch.

+
+    // Set to true if this process' GPU resource count is inflated because
+    // it is counting other processes' resources (e.g, the GPU process has
+    // duplicate set to true because it is the aggregate of all processes)
+    bool has_duplicates;
+  };
+  typedef std::map<base::ProcessId,GPUProcessVidmemUsageStats> ProcessMap;

[jam, 2012/08/17 18:31:05]

nit: space after comma

[ccameron, 2012/08/17 20:52:55]

Done.

+
+  // A map of processes to their GPU resource consumption
+  ProcessMap process_map;
+};
+
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_GPU_INFO_H_