Fixes memory alignment issues due to browser_theme_pack changes

Fixes memory alignment issues due to browser_theme_pack changes.

Bug=141522
Test=No more Arm crash reports

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151090

[sky, 2012-08-09 19:49:16]

http://codereview.chromium.org/10854074/diff/1/chrome/browser/themes/browser_...
File chrome/browser/themes/browser_theme_pack.cc (right):

http://codereview.chromium.org/10854074/diff/1/chrome/browser/themes/browser_...
chrome/browser/themes/browser_theme_pack.cc:195: float* scales = new
float[scales_size];
scoped_array here and 211 (200/202 leak the way you have it now).

[benrg, 2012-08-09 21:45:10]

Random drive-by, sorry.

http://codereview.chromium.org/10854074/diff/1/chrome/browser/themes/browser_...
File chrome/browser/themes/browser_theme_pack.cc (right):

http://codereview.chromium.org/10854074/diff/1/chrome/browser/themes/browser_...
chrome/browser/themes/browser_theme_pack.cc:194: input.size() * sizeof(char) /
sizeof(float));
Either don't multiply by sizeof(char) here or else do divide by it on line 216.
:-)

http://codereview.chromium.org/10854074/diff/1/chrome/browser/themes/browser_...
chrome/browser/themes/browser_theme_pack.cc:195: float* scales = new
float[scales_size];
I think there should be a comment explaining why this copy is needed --
otherwise someone will try to remove it some day.

http://codereview.chromium.org/10854074/diff/1/chrome/browser/themes/browser_...
chrome/browser/themes/browser_theme_pack.cc:199: if (index >= expected.size())
It would be slightly simpler to check scales_size == expected.size() up front
and remove this check and the one on line 205. (And merge line 197 into line
198.)

[pkotwicz, 2012-08-10 00:42:30]

Changes as requested by sky and benrg

[sky, 2012-08-10 16:08:17]

LGTM

http://codereview.chromium.org/10854074/diff/6002/chrome/browser/themes/brows...
File chrome/browser/themes/browser_theme_pack.cc (right):

http://codereview.chromium.org/10854074/diff/6002/chrome/browser/themes/brows...
chrome/browser/themes/browser_theme_pack.cc:197: if (scales_size !=
expected.size())
Move this to 194 (before scoped_array<float>

[sky, 2012-08-10 16:08:28]

Also, make sure this actually solves the problem.

[pkotwicz, 2012-08-10 17:00:28]

I tested this patch on an ARM device and it does solve the problem.

[commit-bot: I haz the power, 2012-08-10 17:00:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10854074/6002

[commit-bot: I haz the power, 2012-08-10 17:07:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10854074/7003

[commit-bot: I haz the power, 2012-08-10 18:22:58]

Change committed as 151090