Extensions Docs Server: Fix handling of nodocs

chrome/common/extensions/docs/server2/converter.py

Index: chrome/common/extensions/docs/server2/converter.py
diff --git a/chrome/common/extensions/docs/server2/converter.py b/chrome/common/extensions/docs/server2/converter.py
index 07f799aaf41f081a509f2ac476d930194a2b13cc..2320663b7d18038141076d71e0cc554be4f8d76a 100755
--- a/chrome/common/extensions/docs/server2/converter.py
+++ b/chrome/common/extensions/docs/server2/converter.py
@@ -30,9 +30,7 @@ IGNORED_FILES = [
   'experimental',
   'samples',
   'index',
-  # These are APIs that should not have docs.
-  'test',
-  'experimental_idltest',
+  'devtools', # Has an intro, but marked as nodoc.

[not at google - send to devlin, 2012/08/09 05:11:36]

You moved this to articles right? So this shouldn't be needed?

[cduvall, 2012/08/09 17:54:05]

This is still needed because devtools.json is in the api folder, so the script
will try to generate an API page. Since it should be generating an articles page
instead, it should be in |IGNORED_FILES|.

[not at google - send to devlin, 2012/08/10 04:48:21]

Sorry my mistake, got this confused with the integration tests.

 ]
 
 # These are mappings for APIs that have no intros. They are needed because the
@@ -186,6 +184,22 @@ def _FormatFile(contents, path, name, image_dest, replace, is_api):
     contents = ('<h1 class="page_title">%s</h1>' % title) + contents
   return contents
 
+def _GetNoDocs(api_dir, api_files):
+  exclude = []
+  for api in api_files:
+    try:
+      with open(os.path.join(api_dir, api), 'r') as f:
+        if os.path.splitext(api)[-1] == '.idl':
+          if '[nodoc] namespace' in f.read():
+            exclude.append(_UnixName(api))
+        else:
+          api_json = json.loads(json_comment_eater.Nom(f.read()))
+          if api_json[0].get('nodoc', False):
+            exclude.append(_UnixName(api))
+    except Exception:
+      pass
+  return exclude
+
 def _ProcessName(name):
   processed_name = []
   if name.startswith('experimental_'):
@@ -216,6 +230,7 @@ def _MoveAllFiles(source_dir,
     original_files.extend(files)
   if replace:
     _CleanAPIs(source_dir, api_dir, intros_dest, template_dest, exclude_files)
+  exclude_files.extend(_GetNoDocs(api_dir, api_files))
   files = set(os.listdir(source_dir))
   unix_files = [_UnixName(f) for f in files]
   for name in  [SanitizeAPIName(f)  for f in _ListAllAPIs(api_dir)]: