Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: base/allocator/allocator.gyp

Issue 10854031: Support vtable_verify (new compiler option). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Do not turn on verification by default. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'jemalloc_dir': '../../third_party/jemalloc/chromium', 7 'jemalloc_dir': '../../third_party/jemalloc/chromium',
8 'tcmalloc_dir': '../../third_party/tcmalloc/chromium', 8 'tcmalloc_dir': '../../third_party/tcmalloc/chromium',
9 }, 9 },
10 'targets': [ 10 'targets': [
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 'ldflags': [ 387 'ldflags': [
388 # Don't let linker rip this symbol out, otherwise the heap&cpu 388 # Don't let linker rip this symbol out, otherwise the heap&cpu
389 # profilers will not initialize properly on startup. 389 # profilers will not initialize properly on startup.
390 '-Wl,-uIsHeapProfilerRunning,-uProfilerStart', 390 '-Wl,-uIsHeapProfilerRunning,-uProfilerStart',
391 # Do the same for heap leak checker. 391 # Do the same for heap leak checker.
392 '-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapP KvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi', 392 '-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapP KvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi',
393 '-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapP KvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl', 393 '-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapP KvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl',
394 '-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakCheck er14UnIgnoreObjectEPKv', 394 '-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakCheck er14UnIgnoreObjectEPKv',
395 ]}, 395 ]},
396 }], 396 }],
397 [ 'use_vtable_verify==1', {
398 'cflags': [
Mark Mentovai 2012/08/13 20:07:12 It is normal in GYP conditions like this to only h
399 '-Wno-sign-compare',
400 '-Wno-unused-result',
401 '-fvtable-verify=preinit',
402 ],
403 'cflags!': [
404 '-fvtable-verify=std',
405 ],
Mark Mentovai 2012/08/13 20:07:12 Fix weird indentation. This should line up with th
406 }],
397 [ 'linux_use_debugallocation==1', { 407 [ 'linux_use_debugallocation==1', {
398 'sources!': [ 408 'sources!': [
399 # debugallocation.cc #includes tcmalloc.cc, 409 # debugallocation.cc #includes tcmalloc.cc,
400 # so only one of them should be used. 410 # so only one of them should be used.
401 '<(tcmalloc_dir)/src/tcmalloc.cc', 411 '<(tcmalloc_dir)/src/tcmalloc.cc',
402 ], 412 ],
403 'defines': [ 413 'defines': [
404 'TCMALLOC_FOR_DEBUGALLOCATION', 414 'TCMALLOC_FOR_DEBUGALLOCATION',
405 ], 415 ],
406 }, { # linux_use_debugallocation != 1 416 }, { # linux_use_debugallocation != 1
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 'dependencies': [ 535 'dependencies': [
526 '../../testing/gtest.gyp:gtest', 536 '../../testing/gtest.gyp:gtest',
527 '../base.gyp:base', 537 '../base.gyp:base',
528 'allocator', 538 'allocator',
529 ], 539 ],
530 }, 540 },
531 ], 541 ],
532 }], 542 }],
533 ], 543 ],
534 } 544 }
OLDNEW
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698