Extension white and force lists (set by policy) should have priority over auto-updated Google black…

chrome/browser/protector/protected_prefs_watcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/protector/protected_prefs_watcher.h"
 
 #include "base/base64.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/stringprintf.h"
@@ skipping 182 matching lines @@
   DCHECK(pref_name && pref_observer_->IsObserved(*pref_name));
   if (UpdateBackupEntry(*pref_name))
     UpdateBackupSignature();
 }
 
 void ProtectedPrefsWatcher::EnsurePrefsMigration() {
   SessionStartupPref::MigrateIfNecessary(profile_->GetPrefs());
 }
 
 bool ProtectedPrefsWatcher::UpdateCachedPrefs() {
-  // Direct access to the extensions prefs is required becase ExtensionService

[Ivan Korotkov, 2012/08/07 13:26:40]

Did something change in the initialization order? Are you sure that now
ExtensionPrefs is always initialized at this moment?

[qfel, 2012/08/07 13:43:51]

I guess I should have left the part about being uninitialized there. I just
moved the code below to ExtensionPrefs::GetExtensionsFrom (which is still a
static method), so ProtectedPrefsWatcher doesn't need to mess with extension
prefs directly (and GetExtensionsFrom uses PrefService now anyway). Nothing
changed in initialization order.

One thing I forgot to mention: now when there are no extension preferences set,
an empty set is returned (and still compared to cached_extension_ids_).
Previously it would always return false, even on non-empty 
cached_extension_ids_. Is that ok? I suppose no preference set at all should be
the same as empty dictionary, but here it was treated differently.

-  // may not yet have been initialized.
-  const base::DictionaryValue* extension_prefs;
-  const base::Value* extension_prefs_value =
-      profile_->GetPrefs()->GetUserPrefValue(ExtensionPrefs::kExtensionsPref);
-  if (!extension_prefs_value ||
-      !extension_prefs_value->GetAsDictionary(&extension_prefs)) {
-    return false;
-  }
   ExtensionPrefs::ExtensionIdSet extension_ids =
-      ExtensionPrefs::GetExtensionsFrom(extension_prefs);
+      ExtensionPrefs::GetExtensionsFrom(profile_->GetPrefs());
   if (extension_ids == cached_extension_ids_)
     return false;
   cached_extension_ids_.swap(extension_ids);
   return true;
 }
 
 bool ProtectedPrefsWatcher::HasBackup() const {
   // TODO(ivankr): as soon as some irreversible change to Preferences happens,
   // add a condition that this change has occured as well (otherwise it's
   // possible to simply clear the "backup" dictionary to make settings
@@ skipping 164 matching lines @@
         NOTREACHED();
         continue;
       }
       StringAppendStringDictionary(tab, &data);
     }
   }
   return data;
 }
 
 }  // namespace protector