Issue 10853007: Set the default locale for ICU in the PPAPI process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10853007: Set the default locale for ICU in the PPAPI process. (Closed)

Created:
8 years, 4 months ago by brettw

Modified:
8 years, 4 months ago

Reviewers:
raymes

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set the default locale for ICU in the PPAPI process. BUG=140432 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149937

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	content/ppapi_plugin/ppapi_plugin_main.cc	View		3 chunks	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

raymes

8 years, 4 months ago (2012-08-03 22:05:17 UTC) #2

lgtm

http://codereview.chromium.org/10853007/diff/1/content/ppapi_plugin/ppapi_plu...
File content/ppapi_plugin/ppapi_plugin_main.cc (right):

http://codereview.chromium.org/10853007/diff/1/content/ppapi_plugin/ppapi_plu...
content/ppapi_plugin/ppapi_plugin_main.cc:15: #include
"ui/base/ui_base_switches.h"
Wrong order.

Expand Messages | Collapse Messages