Add thread assertions in ShareableFileReference

Add thread assertions in ShareableFileReference

BUG=140508
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151002

[michaeln, 2012-08-06 19:26:01]

lgtm

http://codereview.chromium.org/10852017/diff/1/webkit/blob/shareable_file_ref...
File webkit/blob/shareable_file_reference.cc (right):

http://codereview.chromium.org/10852017/diff/1/webkit/blob/shareable_file_ref...
webkit/blob/shareable_file_reference.cc:88: const FinalReleaseCallback&
callback) {
maybe add a DCHECK(g_file_map.Get().CalledOnValidThread())) here too?

[tzik, 2012-08-06 20:12:12]

lgtm

[kinuko, 2012-08-07 00:57:50]

Changed the code to use ThreadChecker as the map gets deleted on UI thread at
the end and hits assertion.  Can you take one more look?

http://codereview.chromium.org/10852017/diff/1/webkit/blob/shareable_file_ref...
File webkit/blob/shareable_file_reference.cc (right):

http://codereview.chromium.org/10852017/diff/1/webkit/blob/shareable_file_ref...
webkit/blob/shareable_file_reference.cc:88: const FinalReleaseCallback&
callback) {
On 2012/08/06 19:26:01, michaeln wrote:
> maybe add a DCHECK(g_file_map.Get().CalledOnValidThread())) here too?

Done.

[michaeln, 2012-08-07 20:14:51]

sure, still lgtm

[commit-bot: I haz the power, 2012-08-09 04:33:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/10852017/13002

[commit-bot: I haz the power, 2012-08-09 04:49:53]

Try job failure for 10852017-13002 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-08-10 04:50:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/10852017/9005

[commit-bot: I haz the power, 2012-08-10 06:24:39]

Change committed as 151002