contacts: Add ContactStoreFactory and FakeContactStore.

chrome/browser/chromeos/contacts/fake_contact_database.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/contacts/fake_contact_database.h"
 
 #include "chrome/browser/chromeos/contacts/contact.pb.h"
 #include "chrome/browser/chromeos/contacts/contact_test_util.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
 
 namespace contacts {
 
 FakeContactDatabase::FakeContactDatabase()
     : init_success_(true),
       save_success_(true),
-      load_success_(true) {
+      load_success_(true),
+      num_saved_contacts_(0) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
 void FakeContactDatabase::Init(const FilePath& database_dir,
                                InitCallback callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   callback.Run(init_success_);
 }
 
 void FakeContactDatabase::SetContacts(const ContactPointers& contacts,
                                       const UpdateMetadata& metadata) {
   test::CopyContacts(contacts, &contacts_);
   metadata_ = metadata;
 }
 
 void FakeContactDatabase::DestroyOnUIThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   delete this;
 }
 
 void FakeContactDatabase::SaveContacts(scoped_ptr<ContactPointers> contacts,
                                        scoped_ptr<UpdateMetadata> metadata,
                                        bool is_full_update,
                                        SaveCallback callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (save_success_) {
-    test::CopyContacts(*contacts, &contacts_);

[Daniel Erat, 2012/08/03 20:00:23]

This bug was hidden by the bug in GoogleContactStore.  I was replacing all the
existing contacts when !is_full_update, but GoogleContactStore was passing all
contacts for partial updates. :-(

+    num_saved_contacts_ += contacts->size();
+    if (is_full_update)
+      test::CopyContacts(*contacts, &contacts_);
+    else
+      MergeContacts(*contacts);
     metadata_ = *metadata;
   }
   callback.Run(save_success_);
 }
 
 void FakeContactDatabase::LoadContacts(LoadCallback callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   scoped_ptr<ScopedVector<Contact> > contacts(new ScopedVector<Contact>());
   scoped_ptr<UpdateMetadata> metadata(new UpdateMetadata);
   if (load_success_) {
     test::CopyContacts(contacts_, contacts.get());
     *metadata = metadata_;
   }
   callback.Run(load_success_, contacts.Pass(), metadata.Pass());
 }
 
 FakeContactDatabase::~FakeContactDatabase() {
 }
 
+void FakeContactDatabase::MergeContacts(
+    const ContactPointers& updated_contacts) {
+  for (ContactPointers::const_iterator updated_it = updated_contacts.begin();
+       updated_it != updated_contacts.end(); ++updated_it) {
+    const Contact& updated_contact = **updated_it;
+    bool found = false;
+    for (ScopedVector<Contact>::const_iterator existing_it = contacts_.begin();

[Daniel Erat, 2012/08/03 20:00:23]

This is ugly and inefficient, but I'm not sure how much it matters.  I could use
map<string, Contact*> instead, but then I'll need to update all of the tests
that call contacts().

[satorux1, 2012/08/03 20:08:14]

Shouldn't matter for tests

+         existing_it != contacts_.end(); ++existing_it) {
+      Contact* existing_contact = *existing_it;
+      if (existing_contact->provider_id() == updated_contact.provider_id()) {
+        *existing_contact = updated_contact;
+        found = true;
+        break;
+      }
+    }
+    if (!found)
+      contacts_.push_back(new Contact(updated_contact));
+  }
+}
+
 }  // namespace contacts