Fix super getter/setter

runtime/vm/ast.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/ast.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/isolate.h"
 #include "vm/object_store.h"
+#include "vm/resolver.h"
 
 
 namespace dart {
 
 #define DEFINE_VISIT_FUNCTION(type, name)                                      \
   void type::Visit(AstNodeVisitor* visitor) {                                  \
     visitor->Visit##type(this);                                                \
   }
 NODE_LIST(DEFINE_VISIT_FUNCTION)
 #undef DEFINE_VISIT_FUNCTION
@@ skipping 295 matching lines @@
 
 
 AstNode* LoadIndexedNode::MakeAssignmentNode(AstNode* rhs) {
   return new StoreIndexedNode(token_pos(), array(), index_expr(), rhs);
 }
 
 
 AstNode* StaticGetterNode::MakeAssignmentNode(AstNode* rhs) {
   // If no setter exist, set the field directly.
   const String& setter_name = String::Handle(Field::SetterName(field_name()));
-  const Function& setter =
-      Function::ZoneHandle(cls().LookupStaticFunction(setter_name));
-  if (setter.IsNull()) {
-    const Field& field = Field::ZoneHandle(
-        cls().LookupStaticField(field_name()));
-    if (field.IsNull()) {
-      // A static getter is declared, but no setter and no field.
-      if (receiver() != NULL) {
-        return new InstanceSetterNode(token_pos(),
-                                      receiver(),
-                                      field_name(),
-                                      rhs);
-      }
-      return NULL;
+
+  if (is_super_getter_) {

[srdjan, 2012/08/08 16:44:34]

Add brief comment what is going on.

[hausner, 2012/08/08 17:42:02]

Done.

+    ASSERT(receiver() != NULL);
+    const Function& super_setter = Function::ZoneHandle(
+        Resolver::ResolveDynamicAnyParams(cls(), setter_name));
+    if (!super_setter.IsNull()) {
+      return new StaticSetterNode(token_pos(),
+                                  receiver(),
+                                  cls(),
+                                  field_name(),
+                                  rhs);
     }
+    return NULL;
+  } else {
+    const Function& setter =
+        Function::ZoneHandle(cls().LookupStaticFunction(setter_name));
+    if (!setter.IsNull()) {
+      return new StaticSetterNode(token_pos(), NULL, cls(), field_name(), rhs);
+    }
+    // Could not find a static setter. Look for a field.
     // Access to a lazily initialized static field that has not yet been
     // initialized is compiled to a static implicit getter.
     // A setter may not exist for such a field.
+    const Field& field =
+        Field::ZoneHandle(cls().LookupStaticField(field_name()));
+    if (!field.IsNull()) {
 #if defined(DEBUG)
-    const String& getter_name = String::Handle(Field::GetterName(field_name()));
-    const Function& getter =
-        Function::ZoneHandle(cls().LookupStaticFunction(getter_name));
-    ASSERT(!getter.IsNull() &&
-           (getter.kind() == RawFunction::kConstImplicitGetter));
+      const String& getter_name =
+          String::Handle(Field::GetterName(field_name()));
+      const Function& getter =
+          Function::ZoneHandle(cls().LookupStaticFunction(getter_name));
+      ASSERT(!getter.IsNull() &&
+             (getter.kind() == RawFunction::kConstImplicitGetter));
 #endif
-    return new StoreStaticFieldNode(token_pos(), field, rhs);
-  } else {
-    return new StaticSetterNode(token_pos(), cls(), field_name(), rhs);
+      return new StoreStaticFieldNode(token_pos(), field, rhs);
+    }
+    // Didn't find a static setter or a static field.
+    // If this static getter is in an instance function where
+    // a receiver is available, we turn this static getter
+    // into an instance setter (and will get an error at runtime if an
+    // instanse setter cannot be found either).

[srdjan, 2012/08/08 16:44:34]

s/instanse/instance/

[hausner, 2012/08/08 17:42:02]

Done.

+    if (receiver() != NULL) {
+      return new InstanceSetterNode(token_pos(),
+                                    receiver(),
+                                    field_name(),
+                                    rhs);
+    }
+    return NULL;
   }
 }
 
 
 const Instance* StaticGetterNode::EvalConstExpr() const {
   const String& getter_name =
       String::Handle(Field::GetterName(this->field_name()));
   const Function& getter_func =
       Function::Handle(this->cls().LookupStaticFunction(getter_name));
   if (getter_func.IsNull() || !getter_func.is_const()) {
     return NULL;
   }
   GrowableArray<const Object*> arguments;
   const Array& kNoArgumentNames = Array::Handle();
   const Object& result =
       Object::Handle(DartEntry::InvokeStatic(getter_func,
                                              arguments,
                                              kNoArgumentNames));
   if (result.IsError() || result.IsNull()) {
     // TODO(turnidge): We could get better error messages by returning
     // the Error object directly to the parser.  This will involve
     // replumbing all of the EvalConstExpr methods.
     return NULL;
   }
   return &Instance::ZoneHandle(Instance::Cast(result).raw());
 }
 
 }  // namespace dart