Issue 10846005: New strings for OOBE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10846005: New strings for OOBE. (Closed)

Created:
8 years, 4 months ago by Nikita (slow)

Modified:
8 years, 4 months ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

New strings for OOBE. BUG=129799 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149886

Patch Set 3 : new #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

lgtm http://codereview.chromium.org/10846005/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10846005/diff/2001/chrome/app/generated_resources.grd#newcode13328 chrome/app/generated_resources.grd:13328: + Please select your keyboard. Are you sure ...

8 years, 4 months ago (2012-08-03 16:43:31 UTC) #2

Nikita (slow)

http://codereview.chromium.org/10846005/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10846005/diff/2001/chrome/app/generated_resources.grd#newcode13328 chrome/app/generated_resources.grd:13328: + Please select your keyboard. On 2012/08/03 16:43:31, Ivan ...

8 years, 4 months ago (2012-08-03 17:32:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10846005/5001

8 years, 4 months ago (2012-08-03 17:33:20 UTC) #4

Change committed as 149886

Expand Messages | Collapse Messages

Issue 10846005: New strings for OOBE. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : new #

Messages