Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 10844005: [Sync] Refactor GetEncryptedTypes usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Always trigger OnEncryptedTypesChanged on init Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index 4335fe12e661d5789d9259be417d933a080f04ca..b6d61d5f6933a3eaf55afa5c2d3e4d4e404319b9 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -383,6 +383,13 @@ void SyncManagerImpl::Init(
unrecoverable_error_handler_ = unrecoverable_error_handler;
report_unrecoverable_error_function_ = report_unrecoverable_error_function;
+ sync_encryption_handler_.reset(new SyncEncryptionHandlerImpl(
+ &share_,
+ encryptor));
+ sync_encryption_handler_->AddObserver(this);
+ sync_encryption_handler_->AddObserver(&debug_info_event_listener_);
+ sync_encryption_handler_->AddObserver(&js_sync_encryption_handler_observer_);
+
FilePath absolute_db_path(database_path_);
file_util::AbsolutePath(&absolute_db_path);
scoped_ptr<syncable::DirectoryBackingStore> backing_store =
@@ -392,10 +399,12 @@ void SyncManagerImpl::Init(
DCHECK(backing_store.get());
share_.name = credentials.email;
share_.directory.reset(
- new syncable::Directory(encryptor_,
- unrecoverable_error_handler_,
- report_unrecoverable_error_function_,
- backing_store.release()));
+ new syncable::Directory(
+ backing_store.release(),
+ unrecoverable_error_handler_,
+ report_unrecoverable_error_function_,
+ sync_encryption_handler_.get(),
+ sync_encryption_handler_->cryptographer_unsafe()));
DVLOG(1) << "Username: " << username_for_share();
if (!OpenDirectory()) {
@@ -465,15 +474,6 @@ void SyncManagerImpl::Init(
trans.GetCryptographer()->BootstrapKeystoreKey(
restored_keystore_key_for_bootstrapping);
- sync_encryption_handler_.reset(new SyncEncryptionHandlerImpl(
- &share_,
- trans.GetCryptographer()));
- sync_encryption_handler_->AddObserver(this);
- sync_encryption_handler_->AddObserver(&debug_info_event_listener_);
- sync_encryption_handler_->AddObserver(&js_sync_encryption_handler_observer_);
- trans.GetCryptographer()->SetNigoriHandler(
- sync_encryption_handler_.get());
-
FOR_EACH_OBSERVER(SyncManager::Observer, observers_,
OnInitializationComplete(
MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()),

Powered by Google App Engine
This is Rietveld 408576698