Move AutocompleteHistoryManager into chrome/browser/autofill/ as it is

Move AutocompleteHistoryManager into chrome/browser/autofill/ as it is
tightly coupled with, and only used by, the autofill feature.  The
only other usage is from TabContents, which initializes and owns an
instance and provides an accessor, but we should be able to remove
this soon.

TBR=ben@chromium.org
BUG=140037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150349

[Jói, 2012-08-03 14:54:43]

First change from exploring Autofill's dependencies.  This one is pretty simple
:) but more will come soon.

CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change there is
just to remove the old location.

Cheers,
Jói

[dhollowa, 2012-08-03 16:26:03]

Autofill and autocomplete are conceptually distinct.  More like "form fill" and
"field fill" respectively.  I'm thinking
chrome/browser/autocomplete/autocomplete_* would reflect this distinction
better.

Ilya, thoughts?

On 2012/08/03 14:54:43, Jói wrote:
> First change from exploring Autofill's dependencies.  This one is pretty
simple
> :) but more will come soon.
> 
> CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change there is
> just to remove the old location.
> 
> Cheers,
> Jói

[Jói, 2012-08-03 16:28:30]

The code I moved is only used by autofill and seems tightly coupled with it.

On Fri, Aug 3, 2012 at 4:26 PM,  <dhollowa@chromium.org> wrote:
> Autofill and autocomplete are conceptually distinct.  More like "form fill"
> and
> "field fill" respectively.  I'm thinking
> chrome/browser/autocomplete/autocomplete_* would reflect this distinction
> better.
>
> Ilya, thoughts?
>
>
> On 2012/08/03 14:54:43, Jói wrote:
>>
>> First change from exploring Autofill's dependencies.  This one is pretty
>
> simple
>>
>> :) but more will come soon.
>
>
>> CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change
>> there is
>> just to remove the old location.
>
>
>> Cheers,
>> Jói
>
>
>
>
> http://codereview.chromium.org/10843067/

[Jói, 2012-08-03 16:31:31]

Meant to add:  Perhaps what's needed is to rename the class and the
IPC messages it uses?  It seems strange if this code is only used by
autofill, and the IPC messages it sends are only used by autofill on
the renderer side, to place it anywhere but under autofill.

Cheers,
Jói


On Fri, Aug 3, 2012 at 4:27 PM, Jói Sigurðsson <joi@chromium.org> wrote:
> The code I moved is only used by autofill and seems tightly coupled with it.
>
> On Fri, Aug 3, 2012 at 4:26 PM,  <dhollowa@chromium.org> wrote:
>> Autofill and autocomplete are conceptually distinct.  More like "form fill"
>> and
>> "field fill" respectively.  I'm thinking
>> chrome/browser/autocomplete/autocomplete_* would reflect this distinction
>> better.
>>
>> Ilya, thoughts?
>>
>>
>> On 2012/08/03 14:54:43, Jói wrote:
>>>
>>> First change from exploring Autofill's dependencies.  This one is pretty
>>
>> simple
>>>
>>> :) but more will come soon.
>>
>>
>>> CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change
>>> there is
>>> just to remove the old location.
>>
>>
>>> Cheers,
>>> Jói
>>
>>
>>
>>
>> http://codereview.chromium.org/10843067/

[dhollowa, 2012-08-03 16:34:37]

Fair enough.  I'm fine with chrome/browser/autofill/autocomplete_*, as it is
pretty clear from the "autocomplete_*" prefix what's going on.  And OWNERS are,
in practice, the same.

On 2012/08/03 16:31:31, Jói wrote:
> Meant to add:  Perhaps what's needed is to rename the class and the
> IPC messages it uses?  It seems strange if this code is only used by
> autofill, and the IPC messages it sends are only used by autofill on
> the renderer side, to place it anywhere but under autofill.
> 
> Cheers,
> Jói
> 
> 
> On Fri, Aug 3, 2012 at 4:27 PM, Jói Sigurðsson <mailto:joi@chromium.org>
wrote:
> > The code I moved is only used by autofill and seems tightly coupled with it.
> >
> > On Fri, Aug 3, 2012 at 4:26 PM,  <mailto:dhollowa@chromium.org> wrote:
> >> Autofill and autocomplete are conceptually distinct.  More like "form fill"
> >> and
> >> "field fill" respectively.  I'm thinking
> >> chrome/browser/autocomplete/autocomplete_* would reflect this distinction
> >> better.
> >>
> >> Ilya, thoughts?
> >>
> >>
> >> On 2012/08/03 14:54:43, Jói wrote:
> >>>
> >>> First change from exploring Autofill's dependencies.  This one is pretty
> >>
> >> simple
> >>>
> >>> :) but more will come soon.
> >>
> >>
> >>> CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change
> >>> there is
> >>> just to remove the old location.
> >>
> >>
> >>> Cheers,
> >>> Jói
> >>
> >>
> >>
> >>
> >> http://codereview.chromium.org/10843067/

[Jói, 2012-08-03 16:39:21]

Cool, thanks.  Keeping this with the code that it's tightly coupled
with helps componentize.  If there is ever a second user of
AutocompleteHistoryManager, it can be made more abstract and extracted
to somewhere to be reused.

Cheers,
Jói


On Fri, Aug 3, 2012 at 4:34 PM,  <dhollowa@chromium.org> wrote:
> Fair enough.  I'm fine with chrome/browser/autofill/autocomplete_*, as it is
> pretty clear from the "autocomplete_*" prefix what's going on.  And OWNERS
> are,
> in practice, the same.
>
>
> On 2012/08/03 16:31:31, Jói wrote:
>>
>> Meant to add:  Perhaps what's needed is to rename the class and the
>> IPC messages it uses?  It seems strange if this code is only used by
>> autofill, and the IPC messages it sends are only used by autofill on
>> the renderer side, to place it anywhere but under autofill.
>
>
>> Cheers,
>> Jói
>
>
>
>> On Fri, Aug 3, 2012 at 4:27 PM, Jói Sigurðsson <mailto:joi@chromium.org>
>
> wrote:
>>
>> > The code I moved is only used by autofill and seems tightly coupled with
>> > it.
>> >
>> > On Fri, Aug 3, 2012 at 4:26 PM,  <mailto:dhollowa@chromium.org> wrote:
>> >> Autofill and autocomplete are conceptually distinct.  More like "form
>> >> fill"
>> >> and
>> >> "field fill" respectively.  I'm thinking
>> >> chrome/browser/autocomplete/autocomplete_* would reflect this
>> >> distinction
>> >> better.
>> >>
>> >> Ilya, thoughts?
>> >>
>> >>
>> >> On 2012/08/03 14:54:43, Jói wrote:
>> >>>
>> >>> First change from exploring Autofill's dependencies.  This one is
>> >>> pretty
>> >>
>> >> simple
>> >>>
>> >>> :) but more will come soon.
>> >>
>> >>
>> >>> CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change
>> >>> there is
>> >>> just to remove the old location.
>> >>
>> >>
>> >>> Cheers,
>> >>> Jói
>> >>
>> >>
>> >>
>> >>
>> >> http://codereview.chromium.org/10843067/
>
>
>
>
> http://codereview.chromium.org/10843067/

[Ilya Sherman, 2012-08-03 18:13:56]

Since David asked: I have no objection to moving this into the autofill/
directory.

On 2012/08/03 16:39:21, Jói wrote:
> Cool, thanks.  Keeping this with the code that it's tightly coupled
> with helps componentize.  If there is ever a second user of
> AutocompleteHistoryManager, it can be made more abstract and extracted
> to somewhere to be reused.
> 
> Cheers,
> Jói
> 
> 
> On Fri, Aug 3, 2012 at 4:34 PM,  <mailto:dhollowa@chromium.org> wrote:
> > Fair enough.  I'm fine with chrome/browser/autofill/autocomplete_*, as it is
> > pretty clear from the "autocomplete_*" prefix what's going on.  And OWNERS
> > are,
> > in practice, the same.
> >
> >
> > On 2012/08/03 16:31:31, Jói wrote:
> >>
> >> Meant to add:  Perhaps what's needed is to rename the class and the
> >> IPC messages it uses?  It seems strange if this code is only used by
> >> autofill, and the IPC messages it sends are only used by autofill on
> >> the renderer side, to place it anywhere but under autofill.
> >
> >
> >> Cheers,
> >> Jói
> >
> >
> >
> >> On Fri, Aug 3, 2012 at 4:27 PM, Jói Sigurðsson <mailto:joi@chromium.org>
> >
> > wrote:
> >>
> >> > The code I moved is only used by autofill and seems tightly coupled with
> >> > it.
> >> >
> >> > On Fri, Aug 3, 2012 at 4:26 PM,  <mailto:dhollowa@chromium.org> wrote:
> >> >> Autofill and autocomplete are conceptually distinct.  More like "form
> >> >> fill"
> >> >> and
> >> >> "field fill" respectively.  I'm thinking
> >> >> chrome/browser/autocomplete/autocomplete_* would reflect this
> >> >> distinction
> >> >> better.
> >> >>
> >> >> Ilya, thoughts?
> >> >>
> >> >>
> >> >> On 2012/08/03 14:54:43, Jói wrote:
> >> >>>
> >> >>> First change from exploring Autofill's dependencies.  This one is
> >> >>> pretty
> >> >>
> >> >> simple
> >> >>>
> >> >>> :) but more will come soon.
> >> >>
> >> >>
> >> >>> CCing ben@ for chrome/OWNERS approval, I plan to TBR since the change
> >> >>> there is
> >> >>> just to remove the old location.
> >> >>
> >> >>
> >> >>> Cheers,
> >> >>> Jói
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> http://codereview.chromium.org/10843067/
> >
> >
> >
> >
> > http://codereview.chromium.org/10843067/

[erikwright (departed), 2012-08-07 13:47:23]

LGTM.