Add OS_CHROMEOS case in file_util::GetHomeDir()

base/chromeos/chromeos_version.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_CHROMEOS_CHROMEOS_VERSION_H_
 #define BASE_CHROMEOS_CHROMEOS_VERSION_H_
 
+#include <string>
+
 #include "base/base_export.h"
 
 namespace base {
 namespace chromeos {
 
 // Returns true if the browser is running on Chrome OS.
 // Useful for implementing stubs for Linux desktop.
 BASE_EXPORT bool IsRunningOnChromeOS();
 
+// Returns the home directory path, or an empty string if the home directory
+// is not found.
+BASE_EXPORT std::string GetHomeDirectory();

[darin (slow to review), 2012/08/02 06:55:35]

Why isn't this just exposed as PathService::Get(base::DIR_HOME)?

[satorux1, 2012/08/02 07:02:32]

That's a great great idea. haruki@, please revise this patch per the suggestion.

[Haruki Sato, 2012/08/03 06:50:01]

Thank you for the helpful advice!

Also talked to kochi@, and I agree that this kind of modification should go into
some generic utility.
I found that PathService already has DIR_HOME and actually calls
file_util::GetHomeDir() for it.
Reverted the changes in this file and fixed it in file_util.


On 2012/08/02 07:02:32, satorux1 wrote:

+
 }  // namespace chromeos
 }  // namespace base
 
 #endif  // BASE_CHROMEOS_CHROMEOS_VERSION_H_