Piping for audio decoding.

remoting/client/audio_decode_scheduler.cc

Index: remoting/client/audio_decode_scheduler.cc
diff --git a/remoting/client/audio_decode_scheduler.cc b/remoting/client/audio_decode_scheduler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b9ff4a35ee219904058871e5330f1f4fa47ac09e
--- /dev/null
+++ b/remoting/client/audio_decode_scheduler.cc
@@ -0,0 +1,54 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/client/audio_decode_scheduler.h"
+
+#include "base/bind.h"
+#include "base/location.h"
+#include "base/single_thread_task_runner.h"
+#include "remoting/client/audio_player.h"
+#include "remoting/proto/audio.pb.h"
+
+namespace remoting {
+
+AudioDecodeScheduler::AudioDecodeScheduler(
+    scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
+    scoped_refptr<base::SingleThreadTaskRunner> audio_decode_task_runner,
+    scoped_ptr<AudioPlayer> audio_player)
+    : main_task_runner_(main_task_runner),
+      audio_decode_task_runner_(audio_decode_task_runner),
+      audio_player_(audio_player.Pass()) {
+}
+
+AudioDecodeScheduler::~AudioDecodeScheduler() {}

[Sergey Ulanov, 2012/08/02 20:32:48]

please move } to the next line - it's preferred formatting for .cc files and
more readable.

[kxing, 2012/08/03 14:51:47]

Done.

+
+void AudioDecodeScheduler::Initialize(const protocol::SessionConfig& config) {
+  decoder_.reset(AudioDecoder::CreateAudioDecoder(config).release());

[Sergey Ulanov, 2012/08/02 20:32:48]

Add DCHECK to verify that this is called on the main thread?

[kxing, 2012/08/03 14:51:47]

Done.

+}
+
+void AudioDecodeScheduler::ProcessAudioPacket(scoped_ptr<AudioPacket> packet,
+                                              const base::Closure& done) {
+  DCHECK(main_task_runner_->BelongsToCurrentThread());
+  audio_decode_task_runner_->PostTask(FROM_HERE, base::Bind(
+      &AudioDecodeScheduler::DecodePacket, base::Unretained(this),
+      base::Passed(packet.Pass())));

[Sergey Ulanov, 2012/08/02 20:32:48]

FYI alternative shorter syntax for Passed: base::Passed(&packet)

[kxing, 2012/08/03 14:51:47]

Done.

+  done.Run();

[Sergey Ulanov, 2012/08/02 20:32:48]

Done should be called only when we are finished decoding it. Move it to
ProcessDecodedPacket()? 

[kxing, 2012/08/03 14:51:47]

Done.

+}
+
+void AudioDecodeScheduler::DecodePacket(scoped_ptr<AudioPacket> packet) {
+  DCHECK(audio_decode_task_runner_->BelongsToCurrentThread());
+  scoped_ptr<AudioPacket> decoded_packet = decoder_->Decode(packet.Pass());
+
+  main_task_runner_->PostTask(FROM_HERE, base::Bind(
+      &AudioDecodeScheduler::ProcessDecodedPacket, base::Unretained(this),
+      base::Passed(decoded_packet.Pass())));
+}
+
+void AudioDecodeScheduler::ProcessDecodedPacket(
+    scoped_ptr<AudioPacket> packet) {
+  DCHECK(main_task_runner_->BelongsToCurrentThread());
+  audio_player_->ProcessAudioPacket(packet.Pass());
+}
+
+}  // namespace remoting