chrome/common/localized_error.cc - Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/localized_error.cc

Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/localized_error.cc

diff --git a/chrome/common/localized_error.cc b/chrome/common/localized_error.cc

index 56dd428a71e22ef395ec374b47713064dcd80540..39b9903b70e2f215d6afd2cf95a0e43c21aaaff5 100644

--- a/chrome/common/localized_error.cc

+++ b/chrome/common/localized_error.cc

@@ -10,6 +10,7 @@

#include "base/string_number_conversions.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

+#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_set.h"

#include "googleurl/src/gurl.h"

@@ -721,7 +722,7 @@ void LocalizedError::GetAppErrorStrings(

error_strings->SetString("title", app->name());

error_strings->SetString("icon",

- app->GetIconURL(ExtensionIconSet::EXTENSION_ICON_GIGANTOR,

+ app->GetIconURL(extension_misc::EXTENSION_ICON_GIGANTOR,

ExtensionIconSet::MATCH_SMALLER).spec());

error_strings->SetString("name", app->name());

error_strings->SetString("msg",

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc ('k') | no next file » | no next file with comments »