chrome/browser/ui/webui/extensions/extension_info_ui.cc - Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_info_ui.cc

Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_info_ui.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_info_ui.cc b/chrome/browser/ui/webui/extensions/extension_info_ui.cc

index 36090cc2c38aa0725b314a1dbf123465df19fc16..346f46c6e1a8f85e82c6404a7938c5ce6ce7cb19 100644

--- a/chrome/browser/ui/webui/extensions/extension_info_ui.cc

+++ b/chrome/browser/ui/webui/extensions/extension_info_ui.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"

#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"

#include "chrome/common/extensions/extension.h"

+#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_ui.h"

@@ -64,7 +65,7 @@ void ExtensionInfoUI::AddExtensionDataToSource(

// Set the icon URL.

GURL icon =

ExtensionIconSource::GetIconURL(extension,

- ExtensionIconSet::EXTENSION_ICON_MEDIUM,

+ extension_misc::EXTENSION_ICON_MEDIUM,

ExtensionIconSet::MATCH_BIGGER,

false, NULL);

source_->AddString("icon", UTF8ToUTF16(icon.spec()));