chrome/browser/background/background_contents_service.cc - Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/background/background_contents_service.cc

diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc

index 9ff318e540ba7d92cc5cd2c1097ecda7baa22744..5bf226e266af8ac8665e1df34b30b46061526839 100644

--- a/chrome/browser/background/background_contents_service.cc

+++ b/chrome/browser/background/background_contents_service.cc

@@ -115,7 +115,7 @@ void ShowBalloon(const Extension* extension, Profile* profile) {

extension->is_app() ? IDS_BACKGROUND_CRASHED_APP_BALLOON_MESSAGE :

IDS_BACKGROUND_CRASHED_EXTENSION_BALLOON_MESSAGE,

UTF8ToUTF16(extension->name()));

- GURL icon_url(extension->GetIconURL(ExtensionIconSet::EXTENSION_ICON_SMALLISH,

+ GURL icon_url(extension->GetIconURL(extension_misc::EXTENSION_ICON_SMALLISH,

ExtensionIconSet::MATCH_BIGGER));

DesktopNotificationService::AddNotification(

extension->url(), title, message, icon_url, string16(),