Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc

Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "chrome/common/extensions/extension.h" 7 #include "chrome/common/extensions/extension.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 TEST_F(ExtensionManifestTest, NormalizeIconPaths) { 10 TEST_F(ExtensionManifestTest, NormalizeIconPaths) {
11 scoped_refptr<extensions::Extension> extension( 11 scoped_refptr<extensions::Extension> extension(
12 LoadAndExpectSuccess("normalize_icon_paths.json")); 12 LoadAndExpectSuccess("normalize_icon_paths.json"));
13 EXPECT_EQ("16.png", extension->icons().Get( 13 EXPECT_EQ("16.png", extension->icons().Get(
14 ExtensionIconSet::EXTENSION_ICON_BITTY, ExtensionIconSet::MATCH_EXACTLY)); 14 ExtensionIconSet::EXTENSION_ICON_BITTY, ExtensionIconSet::MATCH_EXACTLY));
15 EXPECT_EQ("48.png", extension->icons().Get( 15 EXPECT_EQ("48.png", extension->icons().Get(
16 ExtensionIconSet::EXTENSION_ICON_MEDIUM, 16 ExtensionIconSet::EXTENSION_ICON_MEDIUM,
17 ExtensionIconSet::MATCH_EXACTLY)); 17 ExtensionIconSet::MATCH_EXACTLY));
18 } 18 }
19 19
20 TEST_F(ExtensionManifestTest, InvalidIconSizes) { 20 TEST_F(ExtensionManifestTest, InvalidIconSizes) {
21 scoped_refptr<extensions::Extension> extension( 21 scoped_refptr<extensions::Extension> extension(
22 LoadAndExpectSuccess("init_ignored_icon_size.json")); 22 LoadAndExpectSuccess("init_ignored_icon_size.json"));
23 EXPECT_EQ("", extension->icons().Get( 23 EXPECT_EQ("",
24 static_cast<ExtensionIconSet::Icons>(300), 24 extension->icons().Get(300, ExtensionIconSet::MATCH_EXACTLY));
25 ExtensionIconSet::MATCH_EXACTLY));
26 } 25 }
27 26
28 TEST_F(ExtensionManifestTest, ValidIconSizes) { 27 TEST_F(ExtensionManifestTest, ValidIconSizes) {
29 scoped_refptr<extensions::Extension> extension( 28 scoped_refptr<extensions::Extension> extension(
30 LoadAndExpectSuccess("init_valid_icon_size.json")); 29 LoadAndExpectSuccess("init_valid_icon_size.json"));
31 EXPECT_EQ("16.png", extension->icons().Get( 30 EXPECT_EQ("16.png", extension->icons().Get(
32 ExtensionIconSet::EXTENSION_ICON_BITTY, ExtensionIconSet::MATCH_EXACTLY)); 31 ExtensionIconSet::EXTENSION_ICON_BITTY, ExtensionIconSet::MATCH_EXACTLY));
33 EXPECT_EQ("24.png", extension->icons().Get( 32 EXPECT_EQ("24.png", extension->icons().Get(
34 ExtensionIconSet::EXTENSION_ICON_SMALLISH, 33 ExtensionIconSet::EXTENSION_ICON_SMALLISH,
35 ExtensionIconSet::MATCH_EXACTLY)); 34 ExtensionIconSet::MATCH_EXACTLY));
36 EXPECT_EQ("32.png", extension->icons().Get( 35 EXPECT_EQ("32.png", extension->icons().Get(
37 ExtensionIconSet::EXTENSION_ICON_SMALL, ExtensionIconSet::MATCH_EXACTLY)); 36 ExtensionIconSet::EXTENSION_ICON_SMALL, ExtensionIconSet::MATCH_EXACTLY));
38 EXPECT_EQ("48.png", extension->icons().Get( 37 EXPECT_EQ("48.png", extension->icons().Get(
39 ExtensionIconSet::EXTENSION_ICON_MEDIUM, 38 ExtensionIconSet::EXTENSION_ICON_MEDIUM,
40 ExtensionIconSet::MATCH_EXACTLY)); 39 ExtensionIconSet::MATCH_EXACTLY));
41 EXPECT_EQ("128.png", extension->icons().Get( 40 EXPECT_EQ("128.png", extension->icons().Get(
42 ExtensionIconSet::EXTENSION_ICON_LARGE, ExtensionIconSet::MATCH_EXACTLY)); 41 ExtensionIconSet::EXTENSION_ICON_LARGE, ExtensionIconSet::MATCH_EXACTLY));
43 EXPECT_EQ("256.png", extension->icons().Get( 42 EXPECT_EQ("256.png", extension->icons().Get(
44 ExtensionIconSet::EXTENSION_ICON_EXTRA_LARGE, 43 ExtensionIconSet::EXTENSION_ICON_EXTRA_LARGE,
45 ExtensionIconSet::MATCH_EXACTLY)); 44 ExtensionIconSet::MATCH_EXACTLY));
46 EXPECT_EQ("512.png", extension->icons().Get( 45 EXPECT_EQ("512.png", extension->icons().Get(
47 ExtensionIconSet::EXTENSION_ICON_GIGANTOR, 46 ExtensionIconSet::EXTENSION_ICON_GIGANTOR,
48 ExtensionIconSet::MATCH_EXACTLY)); 47 ExtensionIconSet::MATCH_EXACTLY));
49 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698