Issue 1084017: nacl sources should be included conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1084017: nacl sources should be included conditionally (Closed)

Created:
10 years, 9 months ago by appamatto

Modified:
9 years, 7 months ago

Reviewers:
sehr (please use chromium), Alexander Potapenko

CC:
chromium-reviews

Visibility:
Public.

Description

nacl sources should be included conditionally TEST=build with and without disable_nacl=1 BUG=39034

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/chrome_renderer.gypi	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

appamatto

Wasn't sure how to go about this, since http://codereview.chromium.org/969006/show is now closed. Thanks!

10 years, 9 months ago (2010-03-23 14:10:16 UTC) #1

sehr (please use chromium)

LGTM, but I hope we don't need that disable flag for long either.

10 years, 9 months ago (2010-03-23 21:38:56 UTC) #2

appamatto

Me too. Anything else you need from me? (I'm not a committer)

10 years, 9 months ago (2010-03-24 04:10:42 UTC) #3

Alexander Potapenko

10 years, 8 months ago (2010-04-01 10:40:57 UTC) #4

On 2010/03/24 04:10:42, appamatto wrote:
> Me too.  Anything else you need from me?  (I'm not a committer)

I've landed this CL as http://codereview.chromium.org/1562007

Expand Messages | Collapse Messages