Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1084013: Added check to ensure LID is in a closed state before proceeding (Closed)

Created:
10 years, 9 months ago by Sameer Nanda
Modified:
9 years, 5 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Added check to ensure LID is in a closed state before proceeding with suspend-to-RAM. This is to fix a race condition where if the LID is reopened instantaneously after being closed, two LID events get generated (first for LID close and second for LID open). The second event makes the system go back to sleep since the LID state is not being checked. BUG=1961 TEST=manual testing on x200 to make system go to suspend on closing LID

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/platform/acpi/action_lid.sh View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sameer Nanda
10 years, 9 months ago (2010-03-19 22:42:24 UTC) #1
sosa
10 years, 9 months ago (2010-03-19 22:44:25 UTC) #2
lgtm!

Powered by Google App Engine
This is Rietveld 408576698