Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/cpu-profiler.h

Issue 1084010: Fix ARM build (GCC 3 'all member functions in class are private' warning.) (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 class TickSampleEventRecord { 104 class TickSampleEventRecord {
105 public: 105 public:
106 // In memory, the first machine word of a TickSampleEventRecord will be the 106 // In memory, the first machine word of a TickSampleEventRecord will be the
107 // first entry of TickSample, that is -- a program counter field. 107 // first entry of TickSample, that is -- a program counter field.
108 // TickSample is put first, because 'order' can become equal to 108 // TickSample is put first, because 'order' can become equal to
109 // SamplingCircularQueue::kClear, while program counter can't. 109 // SamplingCircularQueue::kClear, while program counter can't.
110 TickSample sample; 110 TickSample sample;
111 unsigned order; 111 unsigned order;
112 112
113 #if defined(__GNUC__) && (__GNUC__ < 4)
114 // Added to avoid 'all member functions in class are private' error.
115 INLINE(unsigned get_order() const) { return order; }
116 #endif
113 private: 117 private:
114 // Disable instantiation. 118 // Disable instantiation.
115 TickSampleEventRecord(); 119 TickSampleEventRecord();
116 120
117 DISALLOW_COPY_AND_ASSIGN(TickSampleEventRecord); 121 DISALLOW_COPY_AND_ASSIGN(TickSampleEventRecord);
118 }; 122 };
119 123
120 124
121 // This class implements both the profile events processor thread and 125 // This class implements both the profile events processor thread and
122 // methods called by event producers: VM and stack sampler threads. 126 // methods called by event producers: VM and stack sampler threads.
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 bool running_; 175 bool running_;
172 CircularQueue<CodeEventsContainer> events_buffer_; 176 CircularQueue<CodeEventsContainer> events_buffer_;
173 SamplingCircularQueue ticks_buffer_; 177 SamplingCircularQueue ticks_buffer_;
174 unsigned enqueue_order_; 178 unsigned enqueue_order_;
175 }; 179 };
176 180
177 181
178 } } // namespace v8::internal 182 } } // namespace v8::internal
179 183
180 #endif // V8_CPU_PROFILER_H_ 184 #endif // V8_CPU_PROFILER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698