chrome/browser/chrome_autofill_client.h - Issue 10837363: Introduce AutofillClient and use it to get rid of PasswordManager dependency.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_autofill_client.h

Issue 10837363: Introduce AutofillClient and use it to get rid of PasswordManager dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/autofill_manager.h ('K') | « chrome/browser/autofill/autofill_metrics_unittest.cc ('k') | chrome/browser/chrome_autofill_client.cc » ('j') | chrome/browser/plugin_infobar_delegates.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROME_AUTOFILL_CLIENT_H_

	6 #define CHROME_BROWSER_CHROME_AUTOFILL_CLIENT_H_

	7

	8 #include "base/compiler_specific.h"

	9 #include "chrome/browser/autofill/api/autofill_client.h"

	10

	11 class TabContents;

	12

	13 // Chrome implementation of AutofillClient

	14 class ChromeAutofillClient : public autofill::AutofillClient {

	15 public:

	16 // Lifetime of \|tab\| must exceed lifetime of ChromeAutofillClient.

	17 ChromeAutofillClient(TabContents* tab);

	18 virtual ~ChromeAutofillClient() {}

	19

	20 virtual InfoBarTabService* GetInfoBarService() OVERRIDE;

	21 virtual PrefServiceBase* GetPrefs() OVERRIDE;

	22 virtual bool IsSavingPasswordsEnabled() OVERRIDE;
	Ilya Sherman 2012/08/22 03:38:03 nit: Should this method be const? nit: Should this method be const? Jói 2012/08/22 17:15:53 Done. Show quoted text On 2012/08/22 03:38:03, Ilya Sherman wrote: > nit: Should this method be const? Done.
	23

	24 private:

	25 TabContents* tab_;
	Ilya Sherman 2012/08/22 03:38:03 nit: Can this be a const-member, i.e. TabContents* nit: Can this be a const-member, i.e. TabContents* const tab_; ? Jói 2012/08/22 17:15:53 Done. Show quoted text On 2012/08/22 03:38:03, Ilya Sherman wrote: > nit: Can this be a const-member, i.e. TabContents* const tab_; ? Done.
	26 };

	27

	28 #endif // CHROME_BROWSER_CHROME_AUTOFILL_CLIENT_H_

OLD	NEW