Setting the touch wrench menu as default menu for ChromeOS

ui/views/controls/menu/menu_separator_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_separator.h"
 
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/native_theme/native_theme.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/controls/menu/menu_config.h"
 
 namespace {
 
 const int kSeparatorHeight = 1;
 
 }  // namespace
 
 namespace views {
 
 void MenuSeparator::OnPaint(gfx::Canvas* canvas) {
-  canvas->FillRect(gfx::Rect(0, height() / 2, width(), kSeparatorHeight),
-      ui::NativeTheme::instance()->GetSystemColor(
-          ui::NativeTheme::kColorId_MenuSeparatorColor));
+  if (type_ == ui::UPPER_SEPARATOR) {
+    canvas->FillRect(gfx::Rect(0, 0, width(), kSeparatorHeight),
+        ui::NativeTheme::instance()->GetSystemColor(

[sky, 2012/08/21 19:36:29]

Since all branches get the color, move it earlier on.

[Mr4D (OOO till 08-26), 2012/08/21 21:34:54]

Not done it that way since that would have read the color for the spacing only
case as well. Instead I was using the position and moved the entire command to
the end.

+            ui::NativeTheme::kColorId_MenuSeparatorColor));
+  } else if (type_ == ui::LOWER_SEPARATOR) {
+    canvas->FillRect(gfx::Rect(0,
+                               height() - kSeparatorHeight,
+                               width(),
+                               kSeparatorHeight),
+        ui::NativeTheme::instance()->GetSystemColor(
+            ui::NativeTheme::kColorId_MenuSeparatorColor));
+  } else if (type_ != ui::SPACING_SEPARATOR) {
+    canvas->FillRect(gfx::Rect(0, height() / 2, width(), kSeparatorHeight),
+        ui::NativeTheme::instance()->GetSystemColor(
+            ui::NativeTheme::kColorId_MenuSeparatorColor));
+  }
 }
 
 gfx::Size MenuSeparator::GetPreferredSize() {
+  int height = MenuConfig::instance().separator_height;
+  switch(type_) {
+    case ui::SPACING_SEPARATOR:
+      height = MenuConfig::instance().separator_spacing_height;
+      break;
+    case ui::LOWER_SEPARATOR:
+      height = MenuConfig::instance().separator_lower_height;
+      break;
+    case ui::UPPER_SEPARATOR:
+      height = MenuConfig::instance().separator_upper_height;
+      break;
+    default:
+      height = MenuConfig::instance().separator_height;
+      break;
+  }
   return gfx::Size(10,  // Just in case we're the only item in a menu.
-                   MenuConfig::instance().separator_height);
+                   height);
 }
 
 }  // namespace views