Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: content/browser/debugger/render_view_devtools_agent_host.cc

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm debug logs Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/render_view_devtools_agent_host.cc
diff --git a/content/browser/debugger/render_view_devtools_agent_host.cc b/content/browser/debugger/render_view_devtools_agent_host.cc
index 4f7313870d4864571a08994d75fedc4f6ff890fd..849f272a32e003826c45330bf3760ad48a0ec7c1 100644
--- a/content/browser/debugger/render_view_devtools_agent_host.cc
+++ b/content/browser/debugger/render_view_devtools_agent_host.cc
@@ -77,9 +77,14 @@ RenderViewDevToolsAgentHost::RenderViewDevToolsAgentHost(
: content::RenderViewHostObserver(rvh),
render_view_host_(rvh) {
g_instances.Get()[rvh] = this;
+}
+
+void RenderViewDevToolsAgentHost::SendMessageToAgent(IPC::Message* msg) {
+ msg->set_routing_id(render_view_host_->GetRoutingID());
+ render_view_host_->Send(msg);
+}
- // Notify that the view is being opened. This allows any views being debugged
- // to do anything special they need to do to support debugging.
+void RenderViewDevToolsAgentHost::NotifyClientOpening() {
content::NotificationService::current()->Notify(
content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING,
content::Source<content::BrowserContext>(
@@ -88,11 +93,6 @@ RenderViewDevToolsAgentHost::RenderViewDevToolsAgentHost(
content::Details<RenderViewHost>(render_view_host_));
}
-void RenderViewDevToolsAgentHost::SendMessageToAgent(IPC::Message* msg) {
- msg->set_routing_id(render_view_host_->GetRoutingID());
- render_view_host_->Send(msg);
-}
-
void RenderViewDevToolsAgentHost::NotifyClientClosing() {
content::NotificationService::current()->Notify(
content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING,

Powered by Google App Engine
This is Rietveld 408576698