chrome/browser/debugger/devtools_window.cc - Issue 10837296: Fix a bug where the inspector would not keep event pages alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/devtools_window.cc

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rm debug logs Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/debugger/devtools_window.cc

diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc

index e1a282b96bb56574ab9679a322cc590866fd3fc1..5c78e0b6f4109e7b8a8eb209794470c87b381f82 100644

--- a/chrome/browser/debugger/devtools_window.cc

+++ b/chrome/browser/debugger/devtools_window.cc

@@ -643,10 +643,12 @@ DevToolsWindow* DevToolsWindow::ToggleDevToolsWindow(

// If window is docked and visible, we hide it on toggle. If window is

// undocked, we show (activate) it.

- if (!window->is_docked() || do_open)

+ if (!window->is_docked() || do_open) {

+ manager->ClientHostOpening(window->frontend_host_);

window->Show(action);

- else

+ } else {

manager->UnregisterDevToolsClientHostFor(agent);

+ }

return window;

}