Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: content/browser/debugger/devtools_agent_host.h

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: yurys Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/devtools_agent_host.h
diff --git a/content/browser/debugger/devtools_agent_host.h b/content/browser/debugger/devtools_agent_host.h
index b4b64087955a307a5b3f9e4ca84a9eea5beb575e..944315b7aa2c5d78fd21b7cb6040da6c1bd37c91 100644
--- a/content/browser/debugger/devtools_agent_host.h
+++ b/content/browser/debugger/devtools_agent_host.h
@@ -35,9 +35,6 @@ class CONTENT_EXPORT DevToolsAgentHost {
void AddMessageToConsole(ConsoleMessageLevel level,
const std::string& message);
- // TODO(yurys): get rid of this method
- virtual void NotifyClientClosing() = 0;
-
virtual int GetRenderProcessId() = 0;
void set_close_listener(CloseListener* listener) {
@@ -49,6 +46,9 @@ class CONTENT_EXPORT DevToolsAgentHost {
virtual ~DevToolsAgentHost() {}
virtual void SendMessageToAgent(IPC::Message* msg) = 0;
+ virtual void NotifyClientAttaching() = 0;
+ virtual void NotifyClientDetaching() = 0;
+
void NotifyCloseListener();
CloseListener* close_listener_;
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_popup.cc ('k') | content/browser/debugger/devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698