Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Side by Side Diff: content/public/browser/devtools_manager.h

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm debug logs Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 // Detaches client from |from_agent| and returns a cookie that allows to 62 // Detaches client from |from_agent| and returns a cookie that allows to
63 // reattach that client to another agent later. Returns -1 if there is no 63 // reattach that client to another agent later. Returns -1 if there is no
64 // client attached to |from_agent|. 64 // client attached to |from_agent|.
65 virtual int DetachClientHost(DevToolsAgentHost* from_agent) = 0; 65 virtual int DetachClientHost(DevToolsAgentHost* from_agent) = 0;
66 // Reattaches client host detached with DetachClientHost method above 66 // Reattaches client host detached with DetachClientHost method above
67 // to |to_agent|. 67 // to |to_agent|.
68 virtual void AttachClientHost(int client_host_cookie, 68 virtual void AttachClientHost(int client_host_cookie,
69 DevToolsAgentHost* to_agent) = 0; 69 DevToolsAgentHost* to_agent) = 0;
70 70
71 // Notification the the given client host is opening a window.
72 virtual void ClientHostOpening(DevToolsClientHost* client_host) = 0;
73
71 // This method will remove all references from the manager to the 74 // This method will remove all references from the manager to the
72 // DevToolsClientHost and unregister all listeners related to the 75 // DevToolsClientHost and unregister all listeners related to the
73 // DevToolsClientHost. Called by closing client. 76 // DevToolsClientHost. Called by closing client.
74 virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0; 77 virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0;
75 78
76 // Starts inspecting element at position (x, y) in the specified page. 79 // Starts inspecting element at position (x, y) in the specified page.
77 virtual void InspectElement(DevToolsAgentHost* agent_host, int x, int y) = 0; 80 virtual void InspectElement(DevToolsAgentHost* agent_host, int x, int y) = 0;
78 81
79 // Logs given |message| on behalf of the given |agent_host|. 82 // Logs given |message| on behalf of the given |agent_host|.
80 virtual void AddMessageToConsole(DevToolsAgentHost* agent_host, 83 virtual void AddMessageToConsole(DevToolsAgentHost* agent_host,
81 ConsoleMessageLevel level, 84 ConsoleMessageLevel level,
82 const std::string& message) = 0; 85 const std::string& message) = 0;
83 86
84 }; 87 };
85 88
86 } // namespace content 89 } // namespace content
87 90
88 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 91 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698