Add bluetooth.getName API.

chrome/browser/chromeos/bluetooth/bluetooth_adapter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_BLUETOOTH_BLUETOOTH_ADAPTER_H_
 #define CHROME_BROWSER_CHROMEOS_BLUETOOTH_BLUETOOTH_ADAPTER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 80 matching lines @@
   // is called, in the success case the callback is simply not called.
   typedef base::Callback<void()> ErrorCallback;
 
   // The BluetoothOutOfBandPairingDataCallback is used to return
   // BluetoothOutOfBandPairingData to the caller.
   typedef base::Callback<void(const BluetoothOutOfBandPairingData& data)>
       BluetoothOutOfBandPairingDataCallback;
 
   // The address of this adapter.  The address format is "XX:XX:XX:XX:XX:XX",
   // where each XX is a hexadecimal number.
-  const std::string& address() const { return address_; }
+  virtual const std::string& address() const;

[Mihai Parparita -not on Chrome, 2012/08/17 20:30:07]

Nit: lowercase names are for basic getters/setters that can be inlined. Virtual
methods are by definition not inlineable, so this should be called GetAddress()
(and the same for name() below)

[keybuk, 2012/08/17 20:31:36]

Is there any particular reason this method has been made virtual?

For testing can't you create the structure with the right member value - I can't
see a reason you'd need to ever "verify that address() or name() are called" ?

[bryeung, 2012/08/20 23:13:19]

Done.

+
+  // The name of the adapter.
+  virtual const std::string& name() const;
 
   // Indicates whether the adapter is actually present on the system, for
   // the default adapter this indicates whether any adapter is present.
   virtual bool IsPresent() const;
 
   // Indicates whether the adapter radio is powered.
   virtual bool IsPowered() const;
 
   // Requests a change to the adapter radio power, setting |powered| to true
   // will turn on the radio and false will turn it off.  On success, callback
@@ skipping 197 matching lines @@
 
   // Object path of adapter for this instance, this is fixed at creation time
   // unless |track_default_| is true in which case we update it to always
   // point at the default adapter.
   bool track_default_;
   dbus::ObjectPath object_path_;
 
   // Address of the adapter.
   std::string address_;
 
+  // Name of the adapter.
+  std::string name_;
+
   // Tracked adapter state, cached locally so we only send change notifications
   // to observers on a genuine change.
   bool powered_;
   bool discovering_;
 
   // Devices paired with, connected to, discovered by, or visible to the
   // adapter. The key is the Bluetooth address of the device and the value
   // is the BluetoothDevice object whose lifetime is managed by the adapter
   // instance.
   typedef std::map<const std::string, BluetoothDevice*> DevicesMap;
   DevicesMap devices_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothAdapter);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_BLUETOOTH_BLUETOOTH_ADAPTER_H_