Cache results in SearchRegExpMultiple.

src/heap.h

Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index f01af258bcd13cef73ac88e6cf1b14dda8f71d82..42dfe00104b66bdb81acb61cf63a31bb69529efb 100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -87,6 +87,7 @@ namespace internal {
   V(Object, instanceof_cache_answer, InstanceofCacheAnswer)                    \
   V(FixedArray, single_character_string_cache, SingleCharacterStringCache)     \
   V(FixedArray, string_split_cache, StringSplitCache)                          \
+  V(FixedArray, regexp_multiple_cache, RegExpMultipleCache)                    \
   V(Object, termination_exception, TerminationException)                       \
   V(Smi, hash_seed, HashSeed)                                                  \
   V(Map, string_map, StringMap)                                                \
@@ -2571,24 +2572,22 @@ class GCTracer BASE_EMBEDDED {
 };
 
 
-class StringSplitCache {
+class RegExpResultsCache {

[ulan, 2012/08/28 08:44:03]

Can we introduce a parameter for this class or its functions that indicates
whether we are using this cache for string split or regex replace? This would
allow more precise checks and help with documentation.

  public:
-  static Object* Lookup(FixedArray* cache, String* string, String* pattern);
+  static Object* Lookup(FixedArray* cache, String* string, Object* pattern);
   static void Enter(Heap* heap,

[ulan, 2012/08/28 08:44:03]

Can we add high level comments for these functions describing pre/post
conditions? Maybe also choose more descriptive name than "array"?

                     FixedArray* cache,
                     String* string,
-                    String* pattern,
+                    Object* pattern,
                     FixedArray* array);
   static void Clear(FixedArray* cache);
-  static const int kStringSplitCacheSize = 0x100;
+  static const int kRegExpResultsCacheSize = 0x100;
 
  private:
   static const int kArrayEntriesPerCacheEntry = 4;
   static const int kStringOffset = 0;
   static const int kPatternOffset = 1;
   static const int kArrayOffset = 2;
-
-  static MaybeObject* WrapFixedArrayInJSArray(Object* fixed_array);
 };