webkit/media/crypto/ppapi/cdm_export.h - Issue 10837252: Update CDM interface and add clear key CDM.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/media/crypto/ppapi/cdm_export.h

Issue 10837252: Update CDM interface and add clear key CDM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update CDM interface and clear key CDM. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « webkit/media/crypto/clear_key_cdm.cc ('k') | webkit/media/crypto/ppapi/content_decryption_module.h » ('j') | webkit/media/crypto/ppapi/content_decryption_module.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WEBKIT_MEDIA_CRYPTO_PPAPI_CDM_EXPORT_H_

	6 #define WEBKIT_MEDIA_CRYPTO_PPAPI_CDM_EXPORT_H_

	7

	8 // Define CDM_EXPORT so that functionality implemented by the CDM module

	9 // can be exported to consumers.

	10

	11 #if defined(COMPONENT_BUILD)
	ddorwin 2012/08/20 21:27:07 Not sure this should be here. See comment in CDM.h Not sure this should be here. See comment in CDM.h. xhwang 2012/08/20 21:57:10 Done. Show quoted text On 2012/08/20 21:27:07, ddorwin wrote: > Not sure this should be here. See comment in CDM.h. Done.
	12 #if defined(WIN32)

	13

	14 #if defined(CDM_IMPLEMENTATION)

	15 #define CDM_EXPORT __declspec(dllexport)

	16 #else

	17 #define CDM_EXPORT __declspec(dllimport)

	18 #endif // defined(CDM_IMPLEMENTATION)

	19

	20 #else // defined(WIN32)
	ddorwin 2012/08/20 21:27:07 !defined ? !defined ? xhwang 2012/08/20 21:57:10 This comment is saying "this '#else' corresponds t Show quoted text On 2012/08/20 21:27:07, ddorwin wrote: > !defined ? This comment is saying "this '#else' corresponds to the above 'defined(WIN32)'". It's ambiguous but it seems to be the style in chromium: http://code.google.com/searchframe#OAMlx_jo-ck/src/content/common/content_exp...
	21 #if defined(CDM_IMPLEMENTATION)

	22 #define CDM_EXPORT __attribute__((visibility("default")))

	23 #else

	24 #define CDM_EXPORT

	25 #endif

	26 #endif

	27

	28 #else // defined(COMPONENT_BUILD)
	ddorwin 2012/08/20 21:27:07 same same xhwang 2012/08/20 21:57:10 Done. Show quoted text On 2012/08/20 21:27:07, ddorwin wrote: > same Done.
	29 #define CDM_EXPORT

	30 #endif

	31

	32 #endif // WEBKIT_MEDIA_CRYPTO_PPAPI_CDM_EXPORT_H_

OLD	NEW