Move browser_test_base.h to content/public/test. I originally thought that content_browsertests wou…

content/test/browser_test_base.cc

Index: content/test/browser_test_base.cc
===================================================================
--- content/test/browser_test_base.cc	(revision 151480)
+++ content/test/browser_test_base.cc	(working copy)
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/test/browser_test_base.h"
+#include "content/public/test/browser_test_base.h"

[Jói, 2012/08/14 16:29:07]

If I understand correctly, the rule is to move the .cc file with the header. 
Shouldn't this file move then?

[jam, 2012/08/14 16:42:22]

content/test didn't obey this. the history is that originally chrome code could
include files from content/test. but then some internal content headers were
leaking through public test headers, so I moved the public ones to
content/public/test.

with your deps improvements, I can now move the cc files to be alongside their
headers,  and enforce that only cc files are including internal headers :) i'll
do that in a followup.

 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ -38,6 +38,8 @@
 
 }  // namespace
 
+namespace content {
+
 BrowserTestBase::BrowserTestBase() {
 #if defined(OS_MACOSX)
   base::mac::SetOverrideAmIBundled(true);
@@ -60,7 +62,7 @@
 
   command_line->AppendSwitch(switches::kDomAutomationController);
 
-  content::MainFunctionParams params(*command_line);
+  MainFunctionParams params(*command_line);
   params.ui_task =
       new base::Closure(
           base::Bind(&BrowserTestBase::ProxyRunTestOnMainThreadLoop, this));
@@ -90,3 +92,5 @@
       net::TestServer::kLocalhost,
       FilePath().AppendASCII(test_server_base)));
 }
+
+}  // namespace content