sync: add InternalComponentsFactory::Switches to simplify passing switches to internal components.

sync/sessions/sync_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/sessions/sync_session.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/logging.h"
@@ skipping 221 matching lines @@
         (update_progress->VerifiedUpdatesBegin() !=
          update_progress->VerifiedUpdatesEnd())) {
       enabled_groups_with_verified_updates.insert(*it);
     }
   }
 
   return enabled_groups_with_verified_updates;
 }
 
 namespace {
-// Return true if the command in question was attempted and did not complete
-// successfully.
-bool IsError(SyncerError error) {
-  return error != UNSET && error != SYNCER_OK;
-}
 
 // Returns false iff one of the command results had an error.
 bool HadErrors(const ModelNeutralState& state) {
-  const bool get_key_error = IsError(state.last_get_key_result);
+  const bool get_key_error = SyncerErrorIsError(state.last_get_key_result);
   const bool download_updates_error =
-      IsError(state.last_download_updates_result);
-  const bool commit_error = IsError(state.commit_result);
+      SyncerErrorIsError(state.last_download_updates_result);
+  const bool commit_error = SyncerErrorIsError(state.commit_result);
   return get_key_error || download_updates_error || commit_error;
 }
 }  // namespace
 
 bool SyncSession::Succeeded() const {
   return finished_ && !HadErrors(status_controller_->model_neutral_state());
 }
 
 bool SyncSession::SuccessfullyReachedServer() const {
   const ModelNeutralState& state = status_controller_->model_neutral_state();
   bool reached_server = state.last_get_key_result == SYNCER_OK ||
                         state.last_download_updates_result == SYNCER_OK;
   // It's possible that we reached the server on one attempt, then had an error
   // on the next (or didn't perform some of the server-communicating commands).
   // We want to verify that, for all commands attempted, we successfully spoke
   // with the server. Therefore, we verify no errors and at least one SYNCER_OK.
   return reached_server && !HadErrors(state);
 }
 
 void SyncSession::SetFinished() {
   finished_ = true;
 }
 
 }  // namespace sessions
 }  // namespace syncer