Move StoragePartition into content/public and remove BrowserContext::GetDOMStorageContext().

content/public/browser/storage_partition.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_STORAGE_PARTITION_H_
+#define CONTENT_PUBLIC_BROWSER_STORAGE_PARTITION_H_
+
+#include "base/basictypes.h"
+
+namespace appcache {
+class AppCacheService;
+}
+
+namespace fileapi {
+class FileSystemContext;
+}
+
+namespace quota {
+class QuotaManager;
+}
+
+namespace webkit_database {
+class DatabaseTracker;
+}
+
+namespace content {
+
+class BrowserContext;
+class IndexedDBContext;
+class DOMStorageContext;
+
+// Defines what persistent state a child process can access.
+//
+// The StoragePartition defines the view each child process has of the
+// persistent state inside the BrowserContext. This is used to implement
+// isolated storage where a renderer with isolated storage cannot see
+// the cookies, localStorage, etc., that normal web renderers have access to.
+class StoragePartition {
+ public:
+  StoragePartition() {}

[jam, 2012/08/15 15:16:22]

nit: don't need, so get rid of (convention we follow with interfaces in public)

[awong, 2012/08/17 00:52:39]

See comment for DISALLOW_COPY_AND_ASSIGN().

[jam, 2012/08/17 16:42:24]

same, only put stuff that's needed. the convention is just to put destructors
(since that's needed). see the rest of the interfaces in content/public :) 

+
+  virtual quota::QuotaManager* GetQuotaManager() = 0;
+  virtual appcache::AppCacheService* GetAppCacheService() = 0;
+  virtual fileapi::FileSystemContext* GetFileSystemContext() = 0;
+  virtual webkit_database::DatabaseTracker* GetDatabaseTracker() = 0;
+  virtual content::DOMStorageContext* GetDOMStorageContext() = 0;

[jam, 2012/08/15 15:16:22]

nit: drop the "content::"

[awong, 2012/08/17 00:52:39]

Done.

+  virtual IndexedDBContext* GetIndexedDBContext() = 0;
+
+ protected:
+  virtual ~StoragePartition() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(StoragePartition);

[jam, 2012/08/15 15:16:22]

nit: not needed since this interface is non-copyable

[awong, 2012/08/17 00:52:39]

I'm not sure I understand.  If we leave both the default constructor and this
out, then I think it *is* copyable.

StoragePartition *a1 = new StoragePartitionImpl();
StoragePartition *a2 = new StoragePartitionImpl();
*a1 = *a2;

This will compile even if StoragePartitionImpl has
DISALLOW_COPY_AND_ASSIGN...it'll just do the wrong thing.  

If we have DISALLOW_COPY_AND_ASSIGN() her eto force this type to be
non-copyable, then we also need the default constructor to be public.

[jam, 2012/08/17 16:42:24]

hmm, I didn't even think that *a1= *a2 would compile. but now that I tried it
out, I see that it does. is this even defined C++ behavior? I tried this with a
simple class and I do see that it's not doing the right thing as you say.

btw it's my understanding that in google3 DISALLOW_COPY_AND_ASSIGN isn't put on
interfaces.

+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_STORAGE_PARTITION_H_