Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 10837211: Draw web content area correctly on a phantom window for window dragging (Closed)

Created:
8 years, 4 months ago by Yusuke Sato
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, oshima, James Cook
Visibility:
Public.

Description

Draw web content area correctly on a phantom window for window dragging. BUG=141766 TEST=1) manual with Lumpy 2) the new unit test passed on try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151826

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : remove WindowPainter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -83 lines) Patch
M ash/wm/window_animations.cc View 4 chunks +3 lines, -31 lines 0 comments Download
M ash/wm/window_util.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 3 chunks +33 lines, -0 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.h View 1 4 chunks +12 lines, -2 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 5 chunks +26 lines, -46 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 3 chunks +11 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 4 chunks +27 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
Scott, could you have a look at this? I've changed phantom window controller to use ...
8 years, 4 months ago (2012-08-13 17:58:27 UTC) #1
sky
http://codereview.chromium.org/10837211/diff/8002/ash/wm/workspace/phantom_window_controller.cc File ash/wm/workspace/phantom_window_controller.cc (right): http://codereview.chromium.org/10837211/diff/8002/ash/wm/workspace/phantom_window_controller.cc#newcode234 ash/wm/workspace/phantom_window_controller.cc:234: // |layer_| except the web content area are not ...
8 years, 4 months ago (2012-08-13 20:56:32 UTC) #2
Yusuke Sato
Please take another look. http://codereview.chromium.org/10837211/diff/8002/ash/wm/workspace/phantom_window_controller.cc File ash/wm/workspace/phantom_window_controller.cc (right): http://codereview.chromium.org/10837211/diff/8002/ash/wm/workspace/phantom_window_controller.cc#newcode234 ash/wm/workspace/phantom_window_controller.cc:234: // |layer_| except the web ...
8 years, 4 months ago (2012-08-15 21:18:23 UTC) #3
sky
LGTM
8 years, 4 months ago (2012-08-16 00:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10837211/6004
8 years, 4 months ago (2012-08-16 00:23:34 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 02:00:06 UTC) #6
Change committed as 151826

Powered by Google App Engine
This is Rietveld 408576698