Pass parsed ChangeList to GDataFileSystem.

chrome/browser/chromeos/gdata/drive_api_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_DRIVE_API_PARSER_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_DRIVE_API_PARSER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/string_piece.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
+#include "chrome/browser/chromeos/gdata/gdata_wapi_parser.h"

[satorux1, 2012/08/10 18:14:34]

This dependency is worrisome. This is for DocumentEntry::EntryKind, right? This
sounds bad, as DocumentEntry will eventually be gone once the migration is done.

We should probably move EntryKind out of DocumentEntry, and put it in a separate
header file like parser_constants.h

[kochi, 2012/08/13 09:08:39]

Once migration is done, EntryKind will not necessary and
parser_constants.h will be empty.  Drive API parser is the
only parser in this directory, drive_api_parser.h is enough
and no reason to have a separate constant definition header.

Even before complete migration to Drive API, once we directly convert to proto,
this isn't necessary.

So I added TODO to remove this dependency.  The same
as the comment for GetKind().

 
 namespace base {
 class Value;
 template <class StructType>
 class JSONValueConverter;
 
 namespace internal {
 template <class NestedType>
 class RepeatedMessageConverter;
 }  // namespace internal
@@ skipping 280 matching lines @@
       base::JSONValueConverter<FileResource>* converter);
 
   // Creates file resource from parsed JSON.
   static scoped_ptr<FileResource> CreateFrom(const base::Value& value);
 
   // Returns true if this is a directory.
   // Note: "folder" is used elsewhere in this file to match Drive API reference,
   // but outside this file we use "directory" to match HTML5 filesystem API.
   bool IsDirectory() const;
 
+  DocumentEntry::EntryKind GetKind() const;
+
   // Returns file ID.  This is unique in all files in Google Drive.
   const std::string& file_id() const { return file_id_; }
 
   // Returns ETag for this file.
   const std::string& etag() const { return etag_; }
 
   // Returns the link to JSON of this file itself.
   const GURL& self_link() const { return self_link_; }
 
   // Returns the title of this file.
@@ skipping 202 matching lines @@
   GURL next_link_;
   int64 largest_change_id_;
   ScopedVector<ChangeResource> items_;
 
   DISALLOW_COPY_AND_ASSIGN(ChangeList);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_DRIVE_API_PARSER_H_