(GTK only) For internal chrome pages display only a bubble with an info string instead of the Websi…

(GTK only) For internal chrome pages display only a bubble with an info string instead of the Website Settings popup.


BUG=140450
TEST=For internal chrome pages like chrome://settings only a small bubble with an info string is displayed.
TBR=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150858

[markusheintz_, 2012-08-08 23:38:27]

Elliot could you please review this CL? Thanks a lot

FYI:
- The websites_settings_utils.* is still pretty empty. But I plan to move all
resource related code (static method) from website_settings_ui.* to the utils
class.

- I also added screenshots to the corresponding bug.

[markusheintz_, 2012-08-09 12:37:13]

On 2012/08/08 23:38:27, markusheintz_ wrote:
> Elliot could you please review this CL? Thanks a lot
> 
> FYI:
> - The websites_settings_utils.* is still pretty empty. But I plan to move all
> resource related code (static method) from website_settings_ui.* to the utils
> class.
> 
> - I also added screenshots to the corresponding bug.

cc'ing dubroy fyi: Please look at the website_settings_utils.* files. I plan to
move all static methods that return resource ids from the website_settings_ui.*
files to the utils files.

[Elliot Glaysher, 2012-08-09 16:41:56]

gtk lgtm

http://codereview.chromium.org/10837174/diff/2001/chrome/browser/ui/gtk/websi...
File chrome/browser/ui/gtk/website_settings_popup_gtk.cc (right):

http://codereview.chromium.org/10837174/diff/2001/chrome/browser/ui/gtk/websi...
chrome/browser/ui/gtk/website_settings_popup_gtk.cc:106: bool closed_by_escape)
{
indentation doesn't align

[markusheintz_, 2012-08-09 16:51:13]

http://codereview.chromium.org/10837174/diff/2001/chrome/browser/ui/gtk/websi...
File chrome/browser/ui/gtk/website_settings_popup_gtk.cc (right):

http://codereview.chromium.org/10837174/diff/2001/chrome/browser/ui/gtk/websi...
chrome/browser/ui/gtk/website_settings_popup_gtk.cc:106: bool closed_by_escape)
{
On 2012/08/09 16:41:56, Elliot Glaysher wrote:
> indentation doesn't align

Done.

[commit-bot: I haz the power, 2012-08-09 16:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10837174/6001

[commit-bot: I haz the power, 2012-08-09 18:44:10]

Change committed as 150858