Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10837145: Add gpu targets to untrusted build, and add Graphics3D code to untrusted build. (Closed)

Created:
8 years, 4 months ago by bbudge
Modified:
8 years, 3 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Add gpu targets to untrusted build, and add Graphics3D code to untrusted build. BUG=116317 TEST=builds,manual With this change, the IPC-based PPAPI proxy builds all code needed for 3d and OpenGL ES. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150432

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+617 lines, -359 lines) Patch
M gpu/command_buffer/client/ref_counted.h View 1 chunk +5 lines, -1 line 0 comments Download
M gpu/command_buffer/command_buffer.gyp View 2 chunks +6 lines, -14 lines 0 comments Download
A gpu/command_buffer/command_buffer.gypi View 1 chunk +30 lines, -0 lines 0 comments Download
A gpu/command_buffer/command_buffer_untrusted.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
M gpu/command_buffer_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/gpu.gyp View 3 chunks +273 lines, -28 lines 0 comments Download
M gpu/gpu_common.gypi View 1 chunk +28 lines, -265 lines 0 comments Download
A gpu/gpu_untrusted.gyp View 1 chunk +116 lines, -0 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 9 chunks +54 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +14 lines, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/ppapi_shared_untrusted.gyp View 1 chunk +9 lines, -3 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 2 chunks +19 lines, -17 lines 1 comment Download
M ppapi/shared_impl/ppb_image_data_shared.cc View 1 1 chunk +12 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 3 chunks +2 lines, -1 line 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bbudge
This is a re-do of http://codereview.chromium.org/10796038/. I had to revert because it broke the static ...
8 years, 4 months ago (2012-08-07 19:25:37 UTC) #1
bbudge
On 2012/08/07 19:25:37, bbudge1 wrote: > This is a re-do of http://codereview.chromium.org/10796038/. > I had ...
8 years, 4 months ago (2012-08-07 19:26:31 UTC) #2
brettw
lgtm http://codereview.chromium.org/10837145/diff/1/ppapi/shared_impl/ppb_image_data_shared.cc File ppapi/shared_impl/ppb_image_data_shared.cc (right): http://codereview.chromium.org/10837145/diff/1/ppapi/shared_impl/ppb_image_data_shared.cc#newcode5 ppapi/shared_impl/ppb_image_data_shared.cc:5: #include "build/build_config.h" This should go below (The .h ...
8 years, 4 months ago (2012-08-07 20:02:53 UTC) #3
bbudge
http://codereview.chromium.org/10837145/diff/1/ppapi/shared_impl/ppb_image_data_shared.cc File ppapi/shared_impl/ppb_image_data_shared.cc (right): http://codereview.chromium.org/10837145/diff/1/ppapi/shared_impl/ppb_image_data_shared.cc#newcode5 ppapi/shared_impl/ppb_image_data_shared.cc:5: #include "build/build_config.h" On 2012/08/07 20:02:53, brettw wrote: > This ...
8 years, 4 months ago (2012-08-07 20:07:57 UTC) #4
greggman
lgtm
8 years, 4 months ago (2012-08-07 20:09:06 UTC) #5
nfullagar
Plz double check CWS apps still work with NaCl proxy - Bastion, Mini-Ninjas, From Dust, ...
8 years, 4 months ago (2012-08-07 20:11:34 UTC) #6
piman
lgtm
8 years, 4 months ago (2012-08-07 20:11:40 UTC) #7
Ami GONE FROM CHROMIUM
post-commit drive-by https://chromiumcodereview.appspot.com/10837145/diff/3002/ppapi/proxy/resource_creation_proxy.cc File ppapi/proxy/resource_creation_proxy.cc (right): https://chromiumcodereview.appspot.com/10837145/diff/3002/ppapi/proxy/resource_creation_proxy.cc#newcode214 ppapi/proxy/resource_creation_proxy.cc:214: printf("ResourceCreationProxy::CreateGraphics3D\n"); What's with this printf() and the ...
8 years, 3 months ago (2012-08-28 18:24:38 UTC) #8
bbudge
8 years, 3 months ago (2012-08-28 18:30:51 UTC) #9
On 2012/08/28 18:24:38, Ami Fischman wrote:
> post-commit drive-by
> 
>
https://chromiumcodereview.appspot.com/10837145/diff/3002/ppapi/proxy/resourc...
> File ppapi/proxy/resource_creation_proxy.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10837145/diff/3002/ppapi/proxy/resourc...
> ppapi/proxy/resource_creation_proxy.cc:214:
> printf("ResourceCreationProxy::CreateGraphics3D\n");
> What's with this printf() and the one below (l.223)?  Did you mean to drop
them
> before checking in?

Yes indeed. Thanks. Fixing.

Powered by Google App Engine
This is Rietveld 408576698