Make java.gypi export jar path to input_jars_paths variable

build/java.gypi

Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index f3d9798f5b01941ee5c8373288996c345672ea83..91db8165874bfc90a4e6e64c25836be56ab2b840 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -26,18 +26,26 @@
 #
 # Finally, the generated jar-file will be:
 #   <(PRODUCT_DIR)/lib.java/chromium_base.jar
-#
-# TODO(yfriedman): The "finally" statement isn't entirely true yet, as we don't
-# auto-generate the ant file yet.
 
 {
+  'direct_dependent_settings': {

[Yaron, 2012/08/07 16:41:09]

This seems to work as-is but I wonder if we'd ultimately want this to be
all_dependent settings. The at the chrome layer, the test says it depends on
chrome_java and picks up all the jars transitively. What do you think?

[cjhopman, 2012/08/07 19:12:11]

So, I've changed it to all_dependent_settings. 

Looking at how normal libraries are handled, it appears that they mostly use
direct_dependent_settings and then the dependent uses export_dependent_settings
so that the settings are passed on to its dependents. I could do it that way,
but the way that this is used, we would just always do export_dependent_settings
and then would essentially be specifying all the *_java dependencies twice.

[Ryan Sleevi, 2012/08/08 05:47:47]

This is indeed the correct and preferred way.

I'm going to have to disagree with Yaron - all_dependent_settings in GYP is a
giant screaming hack. While I realize that shoe-horning Java compilation into
GYP is itself a bit hacky, it does feel "wrong"

Whenever "all_dependent_settings" is present, it's typically a sign of "I depend
on something, but I haven't updated the GYP files to reflect that dependency
tree". When that happens, all sorts of random flakes can be introduced -
particularly when GYP starts pruning dependencies or re-ordering build steps,
and some dependent (file, target) is eliminated, thus it's missing during a
build phase.

I'd like to push back on this, in favor of
direct_dependent+export_dependent_settings.

Really, what I think you want is "link_settings", but since Java hasn't been
added to GYP proper, it doesn't understand that the ant_ step is effectively the
link step (which is when it would merge in link_settings and all would be right
with the world). Perhaps that's something you can investigate?

+    'variables': {
+      'input_jars_paths': ['<(PRODUCT_DIR)/lib.java/chromium_<(package_name).jar'],
+    },
+  },
+  'variables': {
+    'input_jars_paths': [],
+  },
   'actions': [
     {
       'action_name': 'ant_<(package_name)',
       'message': 'Building <(package_name) java sources.',
       'inputs': [
-         '<(java_in_dir)/<(package_name).xml',
-         '<!@(find <(java_in_dir) -name "*.java")'
+        'android/ant/common.xml',
+        'android/ant/chromium-jars.xml',
+        '<(java_in_dir)/<(package_name).xml',
+        '<!@(find <(java_in_dir) -name "*.java")',
+        '>@(input_jars_paths)',
       ],
       'outputs': [
         '<(PRODUCT_DIR)/lib.java/chromium_<(package_name).jar',