gesture recognizer: Make sure the pinch/scroll only when the finger is moved for real.

gesture recognizer: Make sure the pinch/scroll only when the finger is moved for real.

Change in the radius for any of the touch-points changes the bounding box of the points,
but in such cases, we do not want to trigger either scroll or pinch updates.

BUG=none
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150400

[rjkroege, 2012-08-07 15:02:51]

Should there be an another unit test?

otherwise: lgtm

http://codereview.chromium.org/10837107/diff/1/ui/base/gestures/gesture_seque...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/10837107/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:916: if (!points_[i].in_use() ||
!points_[i].DidScroll(event, 2))
aside: the difference between DidScroll and the manhattan square testing code
ought to be clarified. Thoughts?

[sadrul, 2012-08-07 20:28:10]

Added a test.

+Ben for aura owners

http://codereview.chromium.org/10837107/diff/1/ui/base/gestures/gesture_seque...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/10837107/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:916: if (!points_[i].in_use() ||
!points_[i].DidScroll(event, 2))
On 2012/08/07 15:02:51, rjkroege wrote:
> aside: the difference between DidScroll and the manhattan square testing code
> ought to be clarified. Thoughts?

DidScroll looks for movement in any one direction, instead of computing the
manhattan distance. Do you think perhaps DidScroll chould be renamed to make
this clearer?

[Ben Goodger (Google), 2012-08-07 21:20:25]

lgtm

can you make an OWNERS file in ui/aura/gestures?