Issue 10837091: Drive: Adds clearDriveCache API to file_browser_private.

Issue 10837091: Drive: Adds clearDriveCache API to file_browser_private. (Closed)

Created:
8 years, 4 months ago by yoshiki

Modified:
8 years, 4 months ago

Reviewers:
satorux1, asargent_no_longer_on_chrome

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Drive: Adds clearDriveCache API to file_browser_private. This API is to clear all the local cache of Drive. BUG=135197 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149949

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Patch Set 3 : rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/file_browser_private.json	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yoshiki

Antony, could you take a look? This API is just call a method GDataSystemService::ClearCache() to ...

8 years, 4 months ago (2012-08-03 07:42:40 UTC) #1

asargent_no_longer_on_chrome

chrome/{common,browser}/extensions parts LGTM

8 years, 4 months ago (2012-08-03 17:29:40 UTC) #2

yoshiki

satorux: could you take a look at chrome/browser/chromeos/extensions/*?

8 years, 4 months ago (2012-08-03 17:47:31 UTC) #3

satorux1

LGTM with a request. https://chromiumcodereview.appspot.com/10837091/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://chromiumcodereview.appspot.com/10837091/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode2391 chrome/browser/chromeos/extensions/file_browser_private_api.cc:2391: // TODO(yoshiki): Receive a callback ...

8 years, 4 months ago (2012-08-03 17:54:21 UTC) #4

yoshiki

8 years, 4 months ago (2012-08-03 20:09:48 UTC) #5

satorux: Thank you for reviews. I'll check-in this patch after
https://chromiumcodereview.appspot.com/10823125/. (this patch depends on that
patch)

https://chromiumcodereview.appspot.com/10837091/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://chromiumcodereview.appspot.com/10837091/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:2391: //
TODO(yoshiki): Receive a callback from JS-side and pass it to ClearCache().
On 2012/08/03 17:54:21, satorux1 wrote:
> Please file a bug that describes the plan and add a URL here.

Done.

Expand Messages | Collapse Messages