Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3614)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm

Issue 10837090: Change return type of FaviconTabHelper::GetFavicon() to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win? Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm b/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
index 24b1342baef16e1f404d4dcd935b0651e1ce419a..77107f13b3fb2e4a66f858c79073f57a49635753 100644
--- a/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
@@ -19,9 +19,7 @@ namespace mac {
NSImage* FaviconForTabContents(TabContents* contents) {
if (contents && contents->favicon_tab_helper()->FaviconIsValid()) {
- CGColorSpaceRef color_space = base::mac::GetSystemColorSpace();
- NSImage* image = gfx::SkBitmapToNSImageWithColorSpace(
- contents->favicon_tab_helper()->GetFavicon(), color_space);
+ NSImage* image = contents->favicon_tab_helper()->GetFavicon().ToNSImage();
// The |image| could be nil if the bitmap is null. In that case, fallback
// to the default image.
if (image) {

Powered by Google App Engine
This is Rietveld 408576698