Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 10837090: Change return type of FaviconTabHelper::GetFavicon() to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index aab0c3209e3f5d4290782e47fe131433d3f5174e..bc5a5399a79027686c22782ffe30885ec3f4a7fb 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -1074,7 +1074,8 @@ void LocationBarView::OnSetFocus() {
}
SkBitmap LocationBarView::GetFavicon() const {
- return delegate_->GetTabContents()->favicon_tab_helper()->GetFavicon();
+ return delegate_->GetTabContents()->favicon_tab_helper()->
+ GetFavicon().AsBitmap();
}
string16 LocationBarView::GetTitle() const {
@@ -1305,10 +1306,12 @@ void LocationBarView::WriteDragDataForView(views::View* sender,
TabContents* tab_contents = delegate_->GetTabContents();
DCHECK(tab_contents);
+ gfx::ImageSkia favicon =
+ tab_contents->favicon_tab_helper()->GetFavicon().AsImageSkia();
button_drag_utils::SetURLAndDragImage(
tab_contents->web_contents()->GetURL(),
tab_contents->web_contents()->GetTitle(),
- tab_contents->favicon_tab_helper()->GetFavicon(),
+ favicon,
data,
sender->GetWidget());
}
« no previous file with comments | « chrome/browser/ui/views/hung_renderer_view.cc ('k') | chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698