Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 10837090: Change return type of FaviconTabHelper::GetFavicon() to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win? Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h" 5 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 780 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 content::NotificationService::current()->Notify( 791 content::NotificationService::current()->Notify(
792 chrome::NOTIFICATION_ACCESSIBILITY_CONTROL_FOCUSED, 792 chrome::NOTIFICATION_ACCESSIBILITY_CONTROL_FOCUSED,
793 content::Source<Profile>(profile), 793 content::Source<Profile>(profile),
794 content::Details<AccessibilityTextBoxInfo>(&info)); 794 content::Details<AccessibilityTextBoxInfo>(&info));
795 795
796 // Update the keyword and search hint states. 796 // Update the keyword and search hint states.
797 OnChanged(); 797 OnChanged();
798 } 798 }
799 799
800 SkBitmap LocationBarViewGtk::GetFavicon() const { 800 SkBitmap LocationBarViewGtk::GetFavicon() const {
801 return GetTabContents()->favicon_tab_helper()->GetFavicon(); 801 return GetTabContents()->favicon_tab_helper()->GetFavicon().AsBitmap();
802 } 802 }
803 803
804 string16 LocationBarViewGtk::GetTitle() const { 804 string16 LocationBarViewGtk::GetTitle() const {
805 return GetWebContents()->GetTitle(); 805 return GetWebContents()->GetTitle();
806 } 806 }
807 807
808 InstantController* LocationBarViewGtk::GetInstant() { 808 InstantController* LocationBarViewGtk::GetInstant() {
809 return browser_->instant_controller()->instant(); 809 return browser_->instant_controller()->instant();
810 } 810 }
811 811
(...skipping 1184 matching lines...) Expand 10 before | Expand all | Expand 10 after
1996 } 1996 }
1997 1997
1998 void LocationBarViewGtk::PageActionViewGtk::InspectPopup( 1998 void LocationBarViewGtk::PageActionViewGtk::InspectPopup(
1999 ExtensionAction* action) { 1999 ExtensionAction* action) {
2000 ExtensionPopupGtk::Show( 2000 ExtensionPopupGtk::Show(
2001 action->GetPopupUrl(current_tab_id_), 2001 action->GetPopupUrl(current_tab_id_),
2002 owner_->browser_, 2002 owner_->browser_,
2003 event_box_.get(), 2003 event_box_.get(),
2004 ExtensionPopupGtk::SHOW_AND_INSPECT); 2004 ExtensionPopupGtk::SHOW_AND_INSPECT);
2005 } 2005 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698