Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 10837064: Corresponding change in Pepper since EnumerateDevices contract is changed. (Closed)

Created:
8 years, 4 months ago by wjia(left Chromium)
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Corresponding change in Pepper since EnumerateDevices contract is changed. This patch keeps current Pepper API, while using the new API of EnumerateDevices from MediaStreamDispatcher. Pepper calls StopEnumerateDevices when it receives the first enumerated result. A new Pepper API will be created in a separate patch to make EnumerateDevices persistent. BUG=137799

Patch Set 1 #

Total comments: 1

Patch Set 2 : keep current Pepper API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M content/renderer/pepper/pepper_device_enumeration_event_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_input_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_capture_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
http://codereview.chromium.org/10837064/diff/1/ppapi/shared_impl/ppb_audio_input_shared.cc File ppapi/shared_impl/ppb_audio_input_shared.cc (right): http://codereview.chromium.org/10837064/diff/1/ppapi/shared_impl/ppb_audio_input_shared.cc#newcode148 ppapi/shared_impl/ppb_audio_input_shared.cc:148: enumerate_devices_callback_->Run(result); You can't use a completion callback any more. ...
8 years, 4 months ago (2012-08-02 02:36:14 UTC) #1
wjia(left Chromium)
PTAL. This patch keeps current Pepper API so that I can land http://codereview.chromium.org/10830063/. Will do ...
8 years, 4 months ago (2012-08-05 18:26:51 UTC) #2
brettw
8 years, 4 months ago (2012-08-07 19:09:34 UTC) #3
LGTM, sorry for the delay

Powered by Google App Engine
This is Rietveld 408576698