ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

diff --git a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

index 5bf74cb8f8468087f7cb41982ceed3a2c6b5506b..d3454eada7db6877ef8244a181c73cb192d83ce1 100644

--- a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

+++ b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

@@ -30,7 +30,7 @@ void PPB_X509Certificate_Fields::SetField(

PP_Var PPB_X509Certificate_Fields::GetFieldAsPPVar(

PP_X509Certificate_Private_Field field) const {

uint32_t index = static_cast<uint32_t>(field);

- base::Value* value;

+ const base::Value* value;

bool success = values_.Get(index, &value);

if (!success) {

// Our list received might be smaller than the number of fields, so just

« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | sync/internal_api/sync_manager_impl.cc » ('j') | no next file with comments »