Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: chrome/common/extensions/extension.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: David's comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 9177db8af4a9ba2412d5dc3d953bea9ccb36d709..3323f1bfcf9d84548e24de34012d2b1a6ab4c792 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -728,7 +728,7 @@ bool Extension::LoadUserScriptHelper(const DictionaryValue* content_script,
if (js) {
for (size_t script_index = 0; script_index < js->GetSize();
++script_index) {
- Value* value;
+ const Value* value;
std::string relative;
if (!js->Get(script_index, &value) || !value->GetAsString(&relative)) {
*error = ExtensionErrorUtils::FormatErrorMessageUTF16(
@@ -747,7 +747,7 @@ bool Extension::LoadUserScriptHelper(const DictionaryValue* content_script,
if (css) {
for (size_t script_index = 0; script_index < css->GetSize();
++script_index) {
- Value* value;
+ const Value* value;
std::string relative;
if (!css->Get(script_index, &value) || !value->GetAsString(&relative)) {
*error = ExtensionErrorUtils::FormatErrorMessageUTF16(
« no previous file with comments | « chrome/common/extensions/api/extension_api_unittest.cc ('k') | chrome/common/net/gaia/oauth2_mint_token_flow.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698