chrome/browser/ui/webui/options2/manage_profile_handler.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options2/manage_profile_handler.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options2/handler_options_handler.cc ('k') | chrome/browser/ui/webui/options2/startup_pages_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options2/manage_profile_handler.cc

diff --git a/chrome/browser/ui/webui/options2/manage_profile_handler.cc b/chrome/browser/ui/webui/options2/manage_profile_handler.cc

index 9ff6ccbe0dc7a0220a9e679e3bf6ee4f4b36a9ff..0fe67b0be1cdc1b5eeec7993f5359e757f7a4455 100644

--- a/chrome/browser/ui/webui/options2/manage_profile_handler.cc

+++ b/chrome/browser/ui/webui/options2/manage_profile_handler.cc

@@ -152,7 +152,7 @@ void ManageProfileHandler::SendProfileNames() {

void ManageProfileHandler::SetProfileNameAndIcon(const ListValue* args) {

DCHECK(args);

- Value* file_path_value;

+ const Value* file_path_value;

FilePath profile_file_path;

if (!args->Get(0, &file_path_value) ||

!base::GetValueAsFilePath(*file_path_value, &profile_file_path))

@@ -239,7 +239,7 @@ void ManageProfileHandler::DeleteProfile(const ListValue* args) {

ProfileMetrics::LogProfileDeleteUser(ProfileMetrics::PROFILE_DELETED);

- Value* file_path_value;

+ const Value* file_path_value;

FilePath profile_file_path;

if (!args->Get(0, &file_path_value) ||

!base::GetValueAsFilePath(*file_path_value, &profile_file_path))

@@ -253,7 +253,7 @@ void ManageProfileHandler::ProfileIconSelectionChanged(

const base::ListValue* args) {

DCHECK(args);

- Value* file_path_value;

+ const Value* file_path_value;

FilePath file_path;

if (!args->Get(0, &file_path_value) ||

!base::GetValueAsFilePath(*file_path_value, &file_path)) {