chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/invalidations/invalidator_storage.cc ('k') | chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm b/chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm

index 4b088eaf91d17e25f35077f874f8040580a82ff8..f8de658e935ae416f6d1f0ba393dee356f672cd8 100644

--- a/chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm

@@ -104,7 +104,7 @@ void ChromeToMobileBubbleNotificationBridge::OnSendComplete(bool success) {

NSWindow* window = [self window];

const ListValue* mobiles = service_->GetMobiles();

- DictionaryValue* mobile = NULL;

+ const DictionaryValue* mobile = NULL;

string16 name;

if (mobiles->GetSize() == 1) {

@@ -185,7 +185,7 @@ void ChromeToMobileBubbleNotificationBridge::OnSendComplete(bool success) {

// NSMatrix selectedRow is -1 by default (in the single mobile device case).

const int selected_index = std::max<int>([mobileRadioGroup_ selectedRow], 0);

- DictionaryValue* mobile = NULL;

+ const DictionaryValue* mobile = NULL;

if (mobiles->GetDictionary(selected_index, &mobile)) {

service_->SendToMobile(*mobile,

([sendCopy_ state] == NSOnState) ? snapshotPath_ : FilePath(),

« no previous file with comments | « chrome/browser/sync/invalidations/invalidator_storage.cc ('k') | chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc » ('j') | no next file with comments »